Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuel-core-keygen to dockerfile. #2671

Closed
wants to merge 1 commit into from
Closed

Conversation

wengych
Copy link

@wengych wengych commented Feb 5, 2025

Description

Add fuel-core-keygen binary to docker image.

@fuel-cla-bot
Copy link

fuel-cla-bot bot commented Feb 5, 2025

Thanks for the contribution! Before we can merge this, we need @wengych to sign the Fuel Labs Contributor License Agreement.

@AurelienFT
Copy link
Contributor

Hello @wengych, what's the rationale behind this change ?

@wengych
Copy link
Author

wengych commented Feb 5, 2025

Hello @wengych, what's the rationale behind this change ?

I was trying deploy fuel node to docker, and found fuel-core-keygen binary is missing.

@rymnc
Copy link
Member

rymnc commented Feb 6, 2025

@wengych please create a changelog entry in CHANGELOG.md and rebase this PR on top of master :)

@Voxelot
Copy link
Member

Voxelot commented Feb 6, 2025

It doesn't make sense to pollute the base fuel core image with extra utilities that aren't necessary. I.e. the primary fuel-core container should only contain the minimal amount of binaries to get the service running. Extra tools and CLIs could be done via side-cars or new dockerfiles that use this one as a base, as not everyone needs or wants this in every fuel-core container.

@Voxelot Voxelot closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants