Add allow_partial parameter to the "coins to spend" query
#2904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafal-ch
requested review from
xgreenx,
Dentosal,
MitchTurner and
netrome
as code owners
rafal-ch
changed the title
allow_partial parameter to the "coins to spend" query
added 2 commits
March 25, 2025 15:44
xgreenx
reviewed
Mar 25, 2025
Comment on lines
+1102
to
+1106
| excludedIds: ExcludeInput, | ||
| """ | ||
| If true, returns available coins instead of failing when the requested amount is unavailable. | ||
| """ | ||
| allowPartial: Boolean! = false |
There was a problem hiding this comment.
I think it should be optional and part of the SpendQueryElementInput. In this case user can specify which one can be filled partially, and which one can't.
Comment on lines
+108
to
+109
| // TODO[RC]: Support partial flag in the AssembleTx transaction | ||
| let allow_partial = false; |
There was a problem hiding this comment.
When we fetch required balances, it should be false, but when we fetch coins to cover the fee, it can be true
2 tasks
|
Close in favor of #2912 because of CLA. |
AurelienFT
added a commit
that referenced
this pull request
Apr 7, 2025
## Linked Issues/PRs Closes #2898 THIS IS A REVIVAL OF #2904 WITH REVIEW COMMENTS ADDRESSED (because of CLA). Inspiration from Rafal. Kudos to @rafal-ch ! ## Description This PR introduces the new allow_partial parameter to the "coins to spend" inputs query. This field is optional to avoid breaking change. If set to true, the query returns available coins instead of failing when the requested amount is unavailable. I consider this change "non-breaking" since the new parameter is not strictly required when sending the query. ## Checklist - [x] New behavior is reflected in tests ### Before requesting review - [x] I have reviewed the code myself --------- Co-authored-by: Mitchell Turner <james.mitchell.turner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2898
Description
This PR introduces the new
allow_partialparameter to the "coins to spend" query. The default value of this parameters isfalseto preserve the old behavior. If set totrue, the query returns available coins instead of failing when the requested amount is unavailable.I consider this change "non-breaking" since the new parameter is not strictly required when sending the query.
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]