Skip to content

chore!: change balance endpoint return type to u128 #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 17, 2025

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Apr 16, 2025

closes: #2957

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@hal3e hal3e self-assigned this Apr 16, 2025
@hal3e hal3e marked this pull request as ready for review April 16, 2025 13:18
@hal3e hal3e requested review from a team, xgreenx, Dentosal, MitchTurner and netrome as code owners April 16, 2025 13:18
Copy link
Contributor

@AurelienFT AurelienFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xgreenx are we ok to merge breaking api changes for the next release ?

@xgreenx
Copy link
Collaborator

xgreenx commented Apr 16, 2025

Yes, it is just on fuel-core-client side. Plus next release already is breaking for the network and we force everyone to ugprade=)

@hal3e hal3e requested a review from AurelienFT April 16, 2025 20:31
@hal3e hal3e merged commit b218b08 into master Apr 17, 2025
34 checks passed
@hal3e hal3e deleted the chore/get-balance-ruturn-u128 branch April 17, 2025 08:16
Dentosal added a commit that referenced this pull request May 26, 2025
## Version 0.44.0

### Breaking
- [2887](#2887): Bump Rust
version to `1.85.0`.
Starting with this release, newly generated WASM state transition
functions are no longer compatible with old versions of the `fuel-core`.
So, the change breaks forward compatibility for the network and each
node should start to use a new `fuel-core` release.
- [2943](#2943): Registry root
calculation for compression tables no longer accounts for the evictor
cache.
- [2947](#2947): Upgrade to
2024 Rust edition.
- [2958](#2958): Changed
return type of `balance` endpoint from `u64` to `u128`
- [3002](#3002): Update
`fuel-vm` to `0.61.1`. In doing this, we've changed Receipts to use the
`SubId` scalar type for sub asset IDs.

### Added
- [2954](#2954): Made
`registry` mod public in `fuel-core-compression`
- [2956](#2956): Add
excluded_contract filter to extract of transaction from TxPool.
- [2994](#2994): Simple
makefile with basic commands.
- [3004](#3004): Additional
error logs for Ethereum provider failures.

### Changed
- [3021](#3021): Updated
fuel-vm to 0.62.0, see
https://github.com/fuelLabs/fuel-vm/releases/v0.62.0

### Fixed
- [2969](#2969): Ensure that
vm heap memory is zeroed out on rellocation after `reset`. Adds support
for `GM::GetGasPrice` Bumps `fuel-vm` to `0.60.2`.
- [2984](#2984): Fix client
coins endpoint so that passing `None` for `asset_id` no longer defaults
to `AssetId::default()` but correctly returns all asset types.
- [2987](#2987): Make txpool
pre-conf broadcast conditional on there being some txs in the list
- [2989](#2989): Prevent
syncing compression database from genesis if override cli arg
`--da-compression-starting-height` is provided.
- [2992](#2992): Make sure
assemble tx doesn't count message data inputs as spendable inputs for
covering fee
- [2993](#2993): Pin the
graphiql playground to v3, and cache the result to be reused across
multiple calls to render the playground.

### Removed
- [2955](#2955): Remove
unnecessary lifetime constraints on fuel-core-client.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

balance endpoint should return u128
3 participants