Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Address constructor now accepts a range of inputs. #3600

Merged
merged 11 commits into from
Jan 24, 2025

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Jan 20, 2025

Release notes

In this release, we:

  • The Address constructor now accepts a range of different inputs

Summary

  • The Address constructor now accepts a range of inputs:
    • an Address instance
    • a B256 string
    • an EVM address string
    • a public key

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 5:07pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 5:07pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 5:07pm

@petertonysmith94 petertonysmith94 self-assigned this Jan 20, 2025
@petertonysmith94
Copy link
Contributor Author

Opened this PR early (need to update documentation, etc), just to ensure this is the direction we wish to pursue. Does anyone have any issues with this approach?

cc @FuelLabs/sdk-ts @LuizAsFight

Torres-ssf
Torres-ssf previously approved these changes Jan 21, 2025
Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @petertonysmith94 🚀

@Torres-ssf Torres-ssf dismissed their stale review January 21, 2025 13:43

Premature approval

packages/address/src/address.ts Show resolved Hide resolved
Co-authored-by: Sérgio Torres <30977845+Torres-ssf@users.noreply.github.com>
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.07%(+0.03%) 70.72%(+0.08%) 75.14%(+0.04%) 77.07%(+0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 68.46%
(-0.09%)
59%
(+0.54%)
69.89%
(+0%)
68.2%
(-0.08%)
🔴 packages/address/src/address.ts 90.69%
(-0.21%)
92.85%
(+6.19%)
85.71%
(+0%)
90.9%
(-0.17%)
🔴 packages/address/src/utils.ts 80.95%
(+11.72%)
68.75%
(+18.75%)
83.33%
(+5.56%)
81.39%
(+11.02%)

@petertonysmith94 petertonysmith94 merged commit 86b8e94 into master Jan 24, 2025
24 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/chore/improve-address-dx branch January 24, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Address DX
4 participants