-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat: consider assetId
in check account utility
#3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: consider assetId
in check account utility
#3618
Conversation
Coverage Report:
Changed Files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The name of the method getAddressType
is a bit confusing, though, because the returned types Contract
| Transaction
| Blob
| AssetId
are not tied to the concept of an address, unlike Account
which kinda is. It can be thought about and addressed another time, though. No need to make this PR a breaking change.
assets
in check-account utility #3373Release notes
In this release, we:
assetId
onisUserAccount
andgetAddressType
methodsChecklist