Skip to content

feat: consider assetId in check account utility #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 119 commits into from
Mar 5, 2025

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Jan 23, 2025

Release notes

In this release, we:

  • Consider assetId on isUserAccount and getAddressType methods

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Coverage Report:

Lines Branches Functions Statements
77.1%(-0.02%) 70.86%(+0.07%) 75.19%(+0%) 77.1%(-0.02%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 67.63%
(-0.28%)
61.42%
(+0.86%)
68.62%
(+0%)
67.47%
(-0.27%)

Copy link
Contributor

@nedsalk nedsalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The name of the method getAddressType is a bit confusing, though, because the returned types Contract | Transaction | Blob | AssetId are not tied to the concept of an address, unlike Account which kinda is. It can be thought about and addressed another time, though. No need to make this PR a breaking change.

@Torres-ssf Torres-ssf merged commit 0fd8a82 into master Mar 5, 2025
40 of 44 checks passed
@Torres-ssf Torres-ssf deleted the st/feat/consider-asset-id-in-check-account branch March 5, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider assets in check-account utility
5 participants