Resolve TODO and implement TryFrom<Bytes> for b256
#6958
+75
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Do not merge until the next breaking release
Description
impl From<Bytes> for b256
has been removed and replaced withimpl TryFrom<Bytes> for b256
increasing saftey when converting between the two types.impl Into<Bytes> for b256
andimpl TryInto<b256> for Bytes
have also been added.This PR breaks the following implementation:
The implementation should now be:
Checklist
Breaking*
orNew Feature
labels where relevant.