Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trait map to track fully resolved impl type parameters. #6963

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Feb 25, 2025

Description

Updates trait map to track fully resolved impl type parameters.

To be used for trait coherence checking.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen labels Feb 25, 2025
@tritao tritao self-assigned this Feb 25, 2025
@tritao tritao requested a review from a team as a code owner February 25, 2025 21:09
@tritao tritao force-pushed the trait-map-trait-impls branch from 0682aef to 8746dab Compare February 25, 2025 21:13
Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #6963 will degrade performances by 16.86%

Comparing tritao:trait-map-trait-impls (8746dab) with master (a090937)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
hover 3.3 ms 4 ms -16.86%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant