Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ldc opcode in predicates #6964

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

ironcev
Copy link
Member

@ironcev ironcev commented Feb 26, 2025

Description

This PR allows LDC opcode in predicates. Historically, it was not allowed in the FuelVM, but this restriction is removed and we are removing it now from Sway as well.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@ironcev ironcev self-assigned this Feb 26, 2025
@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: codegen Everything to do with IR->ASM, register allocation, etc. labels Feb 26, 2025
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #6964 will not alter performance

Comparing ironcev/allow-ldc-in-predicates (80bf645) with master (a090937)

Summary

✅ 22 untouched benchmarks

@ironcev ironcev marked this pull request as ready for review February 26, 2025 16:34
@ironcev ironcev requested a review from a team as a code owner February 26, 2025 16:34
@ironcev ironcev enabled auto-merge (squash) February 26, 2025 16:34
@ironcev ironcev merged commit 49d0eb4 into master Feb 26, 2025
42 checks passed
@ironcev ironcev deleted the ironcev/allow-ldc-in-predicates branch February 26, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: codegen Everything to do with IR->ASM, register allocation, etc. compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants