Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qna prep materials api #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

qna prep materials api #12

wants to merge 2 commits into from

Conversation

ranit532
Copy link

@ranit532 ranit532 commented Jun 7, 2021

qna prep material api

ArchitW
ArchitW requested changes Jun 8, 2021
View reviewed changes
Copy link

@ArchitW ArchitW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Fix Below I will review again

  1. Fix imports arrange them properly.
  2. why var, why not let or const?

server/controllers/perpMaterialStudentController.js Show resolved Hide resolved
server/controllers/perpMaterialStudentController.js Outdated Show resolved Hide resolved
server/controllers/perpMaterialStudentController.js Outdated Show resolved Hide resolved
server/controllers/perpMaterialStudentController.js Outdated
);
}

var form = new formidable.IncomingForm();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure .. let me make the fixes and I will push by EOD today .

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR.

server/controllers/prepMaterialTeacherController.js Show resolved Hide resolved
server/controllers/prepMaterialTeacherController.js Outdated Show resolved Hide resolved
server/controllers/prepMaterialTeacherController.js Outdated
);
}

var form = new formidable.IncomingForm();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why var , why not let or const?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure .. let me make the fixes and I will push by EOD today .

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR.

server/controllers/prepMaterialTeacherController.js Outdated Show resolved Hide resolved
server/controllers/prepMaterialTeacherController.js Outdated Show resolved Hide resolved
server/controllers/prepMaterialTeacherController.js Outdated Show resolved Hide resolved
@ranit532
Copy link
Author

ranit532 commented Jun 8, 2021

Updated the PR.

@ArchitW
Copy link

ArchitW commented Jun 10, 2021

LGTM, Good to Merge 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArchitW ArchitW ArchitW requested changes

Assignees
No one assigned
Labels
Good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ranit532 @ArchitW @fuelupeducation