Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/new magnets module #2287

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from
Draft

Feature/new magnets module #2287

wants to merge 11 commits into from

Conversation

CoronelBuendia
Copy link
Contributor

@CoronelBuendia CoronelBuendia commented May 30, 2023 •
edited by je-cook
Loading

Linked Issues

Closes #{ID}

Description

⚠️ WIP ⚠️

Draft PR to provide visibility on the updates to the magnets module feature branch.

Needs:

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass flake8 and black .
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@CoronelBuendia CoronelBuendia requested a review from a team as a code owner May 30, 2023 10:15
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2023 •
edited
Loading

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

All warnings (7)

On runtest

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:23: DeprecationWarning: Use of elements created by UFL is deprecated. You should create elements directly using Basix.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/basix/ufl.py:1909: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/expr.py:275: DeprecationWarning: Expr.ufl_domain() is deprecated, please use extract_unique_domain(expr) instead.
  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ffcx/element_interface.py:26: DeprecationWarning: Converting elements created in UFL to Basix elements is deprecated. You should create the elements directly using basix.ufl.element instead
  • /home/runner/work/bluemira/bluemira/bluemira/equilibria/optimisation/harmonics/harmonics_approx_functions.py:41: RuntimeWarning: divide by zero encountered in log10
  • /home/runner/work/bluemira/bluemira/bluemira/radiation_transport/radiation_tools.py:731: DeprecationWarning: interp2dis deprecated!interp2d` is deprecated in SciPy 1.10 and will be removed in SciPy 1.12.0.

For legacy code, nearly bug-for-bug compatible replacements are
RectBivariateSpline on regular grids, and bisplrep/bisplev for
scattered 2D data.

In new code, for regular grids use RegularGridInterpolator instead.
For scattered data, prefer LinearNDInterpolator or
CloughTocher2DInterpolator.

For more details see
https://gist.github.com/ev-br/8544371b40f414b7eaf3fe6217209bff
`

On collect

  • /home/runner/miniconda3/envs/bluemira/lib/python3.10/site-packages/ufl/core/ufl_type.py:56: DeprecationWarning: attach_operators_from_hash_data deprecated, please use UFLObject instead.

@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.45%. Comparing base (104fc74) to head (ed7b8c1).

Files with missing lines Patch % Lines
bluemira/magnets/solenoid_tools.py 96.87% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2287      +/-   ##
===========================================
+ Coverage    76.42%   76.45%   +0.02%     
===========================================
  Files          230      231       +1     
  Lines        26721    26753      +32     
===========================================
+ Hits         20422    20453      +31     
- Misses        6299     6300       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CoronelBuendia CoronelBuendia added this to the Version X.X.X milestone May 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@je-cook je-cook modified the milestones: Version 1.5.0, Version 1.X.X Jul 6, 2023
@je-cook je-cook modified the milestones: Version 1.6.0, Version 1.X.X Aug 22, 2023
@je-cook je-cook modified the milestones: Version 1.7.0, Version 1.8.0 Oct 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@je-cook je-cook modified the milestones: Version 1.8.0, Version 2.0.0 Nov 8, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

14 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@je-cook je-cook modified the milestones: Version 1.9.0, Version 1.X.X Feb 8, 2024
@je-cook je-cook force-pushed the develop branch 5 times, most recently from 5a50acb to 7574352 Compare May 15, 2024 08:13
@je-cook je-cook force-pushed the feature/new_magnet_module branch from 49cf679 to 83e18c2 Compare June 3, 2024 06:01
@je-cook je-cook marked this pull request as draft June 3, 2024 06:01
@je-cook je-cook force-pushed the feature/new_magnet_module branch 2 times, most recently from fb72b27 to d33aa03 Compare June 4, 2024 06:19
@je-cook je-cook force-pushed the feature/new_magnet_module branch 2 times, most recently from 11df9c6 to 3465d37 Compare June 24, 2024 11:41
@je-cook je-cook force-pushed the feature/new_magnet_module branch 2 times, most recently from df28ad1 to d589cd4 Compare July 5, 2024 10:00
@je-cook je-cook force-pushed the feature/new_magnet_module branch from d589cd4 to 782c8f9 Compare July 9, 2024 08:16
CoronelBuendia and others added 11 commits October 10, 2024 10:30
@CoronelBuendia @je-cook
new module folders
8def81a
@CoronelBuendia @je-cook
add example skeleton
d3e8970
@CoronelBuendia @je-cook
add documentation folder
6cf75d8
@CoronelBuendia @je-cook
readme entry
fcc74e7
@CoronelBuendia @je-cook
add to index
b7dbcda
@CoronelBuendia @je-cook
examples in docs
7c788de
@CoronelBuendia @je-cook
update CODEOWNERS for magnets
9f2fb48
@CoronelBuendia @je-cook
CS title
9dba91a
@CoronelBuendia @je-cook
Magnet solenoid tools (#2304)
df18f0d 
* add solenoid tools file

* first pass max field

* first pass hoop stress

* flake8

* max flux

* rename

* docstrings

* axial stress start

* replace estimate with calculation

* remove temp scaffolding

* flake8

* add test

* flkae8

* add livingstone test
@CoronelBuendia @je-cook
licence header
1a3992f
@je-cook
🚨 Ruff fixes
ed7b8c1
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 10, 2024

Quality Gate Passed Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
TSVV-14
Status: In progress
Milestone
Version 2.X.X
Development

Successfully merging this pull request may close these issues.
2 participants
@CoronelBuendia @je-cook