Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix units and unit-conversion factors #2891

Merged
merged 9 commits into from
Jun 4, 2024

Added back in C_LIGHT

c17dd4a
Select commit
Loading
Failed to load commit list.
Merged

Fix units and unit-conversion factors #2891

Added back in C_LIGHT
c17dd4a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 4, 2024 in 0s

74.29% (-5.69%) compared to fb8a051

View this Pull Request on Codecov

74.29% (-5.69%) compared to fb8a051

Details

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.29%. Comparing base (fb8a051) to head (c17dd4a).
Report is 100 commits behind head on develop.

Files Patch % Lines
bluemira/fuel_cycle/cycle.py 0.00% 6 Missing ⚠️
bluemira/fuel_cycle/lifecycle.py 0.00% 1 Missing ⚠️
bluemira/fuel_cycle/timeline.py 0.00% 1 Missing ⚠️
bluemira/plasma_physics/collisions.py 75.00% 1 Missing ⚠️
bluemira/plasma_physics/rules_of_thumb.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2891      +/-   ##
===========================================
- Coverage    79.98%   74.29%   -5.69%     
===========================================
  Files          222      242      +20     
  Lines        24759    26861    +2102     
===========================================
+ Hits         19804    19957     +153     
- Misses        4955     6904    +1949

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov