SH Plotting #3023
Merged
SH Plotting #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clmould
force-pushed
the
clair/sh-plotting
branch
3 times, most recently
from
2809d2f
to
3015955
Compare
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/eq_analysis_tools #3023 +/- ##
=============================================================
- Coverage 76.35% 75.52% -0.83%
=============================================================
Files 231 232 +1
Lines 26652 26849 +197
=============================================================
- Hits 20351 20279 -72
- Misses 6301 6570 +269 ☔ View full report in Codecov by Sentry. |
clmould
force-pushed
the
clair/sh-plotting
branch
2 times, most recently
from
1170ed3
to
cda23ac
Compare
|
je-cook
reviewed
Apr 18, 2024
clmould
force-pushed
the
clair/sh-plotting
branch
from
4e35a91
to
0c2a871
Compare
je-cook
reviewed
May 2, 2024
|
je-cook
added
equilibria
|
Hey, could you add a few lines to the description? I don't think the original issue fully covers the extra plotting features you have added. |
|
Currently we have the option to plot the 'full' psi or 'split' psi contributions. The alternative is to plot all three (total, plasma, coilset) along side each other. Pro = would remove a plotting option input. Con = might be a lot to look at at once during an optimisation. What do you (@clmould, @oliverfunk, @je-cook) think? (This is something we had talked about before but not decided on). |
I have no preference it more what people think is useful. My only blocker on here atm is there is no test to cover 80% of this which is needed. Btw to view figures while testing you can use the |
je-cook
force-pushed
the
develop
branch
5 times, most recently
from
5a50acb
to
7574352
Compare
- compare equilibrium object with reference equilibrium - split psi plotting - plotting percentage difference between current and reference equilibrium - plot reference lcfs
…in _minimal_current
clmould
force-pushed
the
clair/sh-plotting
branch
from
2a2d02d
to
58a8085
Compare
|
je-cook
merged commit a72188d
into
Fusion-Power-Plant-Framework:feature/eq_analysis_tools
6 of 8 checks passed
je-cook
added a commit
that referenced
this pull request
Aug 29, 2024
* Create equilibrium comparison plotter class - compare equilibrium object with reference equilibrium - split psi plotting - plotting percentage difference between current and reference equilibrium - plot reference lcfs * work on plots before work to update plot instead of producing new plots * make subplots have the same axes limits * remove unused argument in call to EquilibriumComparisonPlotter class in _minimal_current * Add xz_plot_setup to plot_tools.py * working on updating plot * remove blank line after docstring * trying to update colorbar (from stackexchange) * colorbar updating instead of multiple colorbars * add # noqa: BLE001 to Exception * update typing * pre-commit changes * fix from github comment * 🚨 Few missing imports --------- Co-authored-by: james <james.cook1@ukaea.uk>
je-cook
added a commit
that referenced
this pull request
Sep 13, 2024
* Create equilibrium comparison plotter class - compare equilibrium object with reference equilibrium - split psi plotting - plotting percentage difference between current and reference equilibrium - plot reference lcfs * work on plots before work to update plot instead of producing new plots * make subplots have the same axes limits * remove unused argument in call to EquilibriumComparisonPlotter class in _minimal_current * Add xz_plot_setup to plot_tools.py * working on updating plot * remove blank line after docstring * trying to update colorbar (from stackexchange) * colorbar updating instead of multiple colorbars * add # noqa: BLE001 to Exception * update typing * pre-commit changes * fix from github comment * 🚨 Few missing imports --------- Co-authored-by: james <james.cook1@ukaea.uk>
geograham
pushed a commit
that referenced
this pull request
Oct 3, 2024
* Create equilibrium comparison plotter class - compare equilibrium object with reference equilibrium - split psi plotting - plotting percentage difference between current and reference equilibrium - plot reference lcfs * work on plots before work to update plot instead of producing new plots * make subplots have the same axes limits * remove unused argument in call to EquilibriumComparisonPlotter class in _minimal_current * Add xz_plot_setup to plot_tools.py * working on updating plot * remove blank line after docstring * trying to update colorbar (from stackexchange) * colorbar updating instead of multiple colorbars * add # noqa: BLE001 to Exception * update typing * pre-commit changes * fix from github comment * 🚨 Few missing imports --------- Co-authored-by: james <james.cook1@ukaea.uk>
je-cook
added a commit
that referenced
this pull request
Oct 10, 2024
* Create equilibrium comparison plotter class - compare equilibrium object with reference equilibrium - split psi plotting - plotting percentage difference between current and reference equilibrium - plot reference lcfs * work on plots before work to update plot instead of producing new plots * make subplots have the same axes limits * remove unused argument in call to EquilibriumComparisonPlotter class in _minimal_current * Add xz_plot_setup to plot_tools.py * working on updating plot * remove blank line after docstring * trying to update colorbar (from stackexchange) * colorbar updating instead of multiple colorbars * add # noqa: BLE001 to Exception * update typing * pre-commit changes * fix from github comment * 🚨 Few missing imports --------- Co-authored-by: james <james.cook1@ukaea.uk>
je-cook
added a commit
that referenced
this pull request
Oct 21, 2024
* Create equilibrium comparison plotter class - compare equilibrium object with reference equilibrium - split psi plotting - plotting percentage difference between current and reference equilibrium - plot reference lcfs * work on plots before work to update plot instead of producing new plots * make subplots have the same axes limits * remove unused argument in call to EquilibriumComparisonPlotter class in _minimal_current * Add xz_plot_setup to plot_tools.py * working on updating plot * remove blank line after docstring * trying to update colorbar (from stackexchange) * colorbar updating instead of multiple colorbars * add # noqa: BLE001 to Exception * update typing * pre-commit changes * fix from github comment * 🚨 Few missing imports --------- Co-authored-by: james <james.cook1@ukaea.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Closes #3080
Description
A new class called EquilibriumComparisonPlotter has been created which allows equilibrium plotting and comparing to a reference equilibrium. The plotting options allow for splitting the psi plots to show the coilset psi and plasma psi, and also a difference plot which plots the relative difference in psi between the current and reference equilibrium. For all the plotting options, the reference LCFS and current LCFS are overlaid on the plots.
Interface Changes
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build