Equilibria analysis feature branch #3338
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
je-cook
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3338 +/- ##
===========================================
- Coverage 76.42% 75.00% -1.43%
===========================================
Files 230 232 +2
Lines 26721 27313 +592
===========================================
+ Hits 20422 20485 +63
- Misses 6299 6828 +529 ☔ View full report in Codecov by Sentry. |
|
je-cook
force-pushed
the
feature/eq_analysis_tools
branch
3 times, most recently
from
0513c8c
to
fe1191a
Compare
je-cook
force-pushed
the
feature/eq_analysis_tools
branch
2 times, most recently
from
a51f25f
to
0d03612
Compare
je-cook
force-pushed
the
feature/eq_analysis_tools
branch
from
0d03612
to
a518506
Compare
je-cook
force-pushed
the
feature/eq_analysis_tools
branch
2 times, most recently
from
dfe56b1
to
9f6c09f
Compare
je-cook
force-pushed
the
feature/eq_analysis_tools
branch
from
9caa070
to
d5ed6b4
Compare
je-cook
force-pushed
the
feature/eq_analysis_tools
branch
from
d5ed6b4
to
0ca76ec
Compare
geograham
force-pushed
the
feature/eq_analysis_tools
branch
from
0ca76ec
to
323fdf2
Compare
* 🎨 Small cleanup * 🚧 Initial structure
* Create equilibrium comparison plotter class - compare equilibrium object with reference equilibrium - split psi plotting - plotting percentage difference between current and reference equilibrium - plot reference lcfs * work on plots before work to update plot instead of producing new plots * make subplots have the same axes limits * remove unused argument in call to EquilibriumComparisonPlotter class in _minimal_current * Add xz_plot_setup to plot_tools.py * working on updating plot * remove blank line after docstring * trying to update colorbar (from stackexchange) * colorbar updating instead of multiple colorbars * add # noqa: BLE001 to Exception * update typing * pre-commit changes * fix from github comment * 🚨 Few missing imports --------- Co-authored-by: james <james.cook1@ukaea.uk>
je-cook
force-pushed
the
feature/eq_analysis_tools
branch
from
673d75a
to
749d754
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Equilibria analysis feature branch closes #675.
(Other relevant issues: #431, #985, #3080, #3376)
Interface Changes
Checklist
I confirm that I have completed the following checks:
pytest tests --reactorpre-commit run --from-ref develop --to-ref HEADsphinx-build -W documentation/source documentation/build