Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Logging cleanup #3614

Merged
merged 4 commits into from
Sep 30, 2024
Merged

🎨 Logging cleanup #3614

merged 4 commits into from
Sep 30, 2024

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Sep 18, 2024

Description

Moves some logging mechanics to a lower level so it is collated, some work towards #3399

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added the base Tasks relating to the base module label Sep 18, 2024
@je-cook je-cook marked this pull request as ready for review September 18, 2024 12:11
@je-cook je-cook requested a review from a team as a code owner September 18, 2024 12:11
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 98.68421% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.42%. Comparing base (5b90839) to head (d1ae538).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
bluemira/codes/process/_run.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3614      +/-   ##
===========================================
+ Coverage    76.38%   76.42%   +0.03%     
===========================================
  Files          230      230              
  Lines        26677    26721      +44     
===========================================
+ Hits         20378    20422      +44     
  Misses        6299     6299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@oliverfunk oliverfunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

bluemira/base/look_and_feel.py Outdated Show resolved Hide resolved
bluemira/base/logs.py Outdated Show resolved Hide resolved
@je-cook
Copy link
Contributor Author

je-cook commented Sep 26, 2024

I've rearranged some things here so the comment dont really fit could you have another look?

@je-cook je-cook force-pushed the je-cook/logging branch 2 times, most recently from 7e85fbb to dd07ada Compare September 27, 2024 10:37
Copy link

sonarcloud bot commented Sep 30, 2024

Copy link
Contributor

@oliverfunk oliverfunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah lgtm

@je-cook je-cook merged commit b3f1c93 into develop Sep 30, 2024
11 checks passed
@je-cook je-cook deleted the je-cook/logging branch September 30, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base Tasks relating to the base module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants