Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix demo bug #3620

Merged
merged 1 commit into from
Sep 24, 2024
Merged

🐛 Fix demo bug #3620

merged 1 commit into from
Sep 24, 2024

Conversation

je-cook
Copy link
Contributor

@je-cook je-cook commented Sep 24, 2024

Description

Demo syntax error because component managers have slightly changed

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@je-cook je-cook added bug Something isn't working EU-DEMO Tasks relating to the EU-DEMO project labels Sep 24, 2024
@je-cook je-cook requested a review from a team as a code owner September 24, 2024 08:22
Copy link

sonarcloud bot commented Sep 24, 2024

@je-cook je-cook enabled auto-merge (squash) September 24, 2024 08:24
@je-cook je-cook merged commit 1616b57 into develop Sep 24, 2024
9 checks passed
@je-cook je-cook deleted the je-cook/demo_bug branch September 24, 2024 08:34
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.40%. Comparing base (b67bf2c) to head (ec451e3).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3620      +/-   ##
===========================================
- Coverage    76.42%   76.40%   -0.02%     
===========================================
  Files          230      230              
  Lines        26706    26706              
===========================================
- Hits         20411    20406       -5     
- Misses        6295     6300       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EU-DEMO Tasks relating to the EU-DEMO project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants