Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core radiation fix #3624

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Core radiation fix #3624

wants to merge 4 commits into from

Conversation

DarioV86
Copy link
Contributor

@DarioV86 DarioV86 commented Oct 1, 2024

The core radiation was not calculated correctly because when accessing the tables from ADAS stored in PROCESS, Lz and Zeff where accessed with a reference temperature in keV instead of eV.

Besides the radiation calculation fix, a few checks related to the effective charge profiles and the average Z_eff value across the plasma were added.

Also added a scaling factor to use non-uniform electron temperature and electron density along the closed flux lines in the plasma core.

@DarioV86 DarioV86 requested a review from a team as a code owner October 1, 2024 09:34
@DarioV86 DarioV86 requested a review from je-cook October 1, 2024 09:35
@je-cook je-cook added bug Something isn't working radiation_transport Tasks relating to radiation transport labels Oct 1, 2024
je-cook
je-cook reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to take me a bit of time to go through. Here are a few things to start

bluemira/radiation_transport/radiation_profile.py Outdated Show resolved Hide resolved
bluemira/radiation_transport/radiation_profile.py Outdated Show resolved Hide resolved
bluemira/radiation_transport/radiation_profile.py Outdated Show resolved Hide resolved
bluemira/radiation_transport/radiation_profile.py Show resolved Hide resolved
je-cook
je-cook requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I have no knowledge of where most of this maths come from so could we have a few references or documents for that?

The code itself looks fine although the tests need fixing

bluemira/radiation_transport/radiation_profile.py Outdated Show resolved Hide resolved
bluemira/radiation_transport/radiation_profile.py Outdated Show resolved Hide resolved
bluemira/radiation_transport/radiation_tools.py Outdated Show resolved Hide resolved
@je-cook je-cook added the enhancement New feature or request label Oct 16, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@je-cook
Copy link
Contributor

je-cook commented Oct 18, 2024 •
edited
Loading

Ok there are tests for calculate_z_species that need changing/updating/removing because you've removed the function here. There are some other failures too because of name changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@je-cook je-cook je-cook requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request radiation_transport Tasks relating to radiation transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarioV86 @je-cook