👽️ PROCESS develop api changes #3636

je-cook · 2024-10-11T15:15:39Z

Description

Updates our PROCESS api for the current develop version of PROCESS.

closes #3650 as of process 3108

Interface Changes

Many....
Still todo:

check for any leftover old variable names code wide
check process example
REVERT private data branch

Checklist

I confirm that I have completed the following checks:

Tests run locally and pass pytest tests --reactor
Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
Documentation built locally and checked sphinx-build -W documentation/source documentation/build

codecov · 2024-10-11T15:32:05Z

Codecov Report

Attention: Patch coverage is 84.18079% with 56 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (94d9455) to head (1c8b0b0).
Report is 7 commits behind head on develop.

Files with missing lines	Patch %	Lines
bluemira/codes/process/_solver.py	12.50%	35 Missing ⚠️
bluemira/codes/process/model_mapping.py	74.32%	19 Missing ⚠️
bluemira/codes/process/_run.py	33.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3636      +/-   ##
===========================================
+ Coverage    77.46%   77.65%   +0.19%     
===========================================
  Files          246      246              
  Lines        29191    29380     +189     
===========================================
+ Hits         22612    22816     +204     
+ Misses        6579     6564      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2024-11-25T15:33:54Z

⚠️ Warning Report

Found 1 new warning, 1 fixed warning.

New warnings (1)

On collect

/home/runner/work/bluemira/process/process/io/python_fortran_dicts.py:13: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html

All warnings (4)

On collect

/home/runner/miniconda3/envs/bluemira/lib/python3.11/site-packages/pkg_resources/__init__.py:3138: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('sphinxcontrib'). Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
/home/runner/miniconda3/envs/bluemira/lib/python3.11/site-packages/pkg_resources/__init__.py:3138: DeprecationWarning: Deprecated call to pkg_resources.declare_namespace('cherab'). Implementing implicit namespace packages (as specified in PEP 420) is preferred to pkg_resources.declare_namespace. See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages
/home/runner/work/bluemira/process/process/io/python_fortran_dicts.py:13: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html

On runtest

/home/runner/work/bluemira/bluemira/bluemira/codes/process/api.py:150: DeprecationWarning: path is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.

je-cook · 2025-01-31T08:46:05Z

.github/workflows/ci.yml

@@ -48,7 +48,7 @@ jobs:
      matrix:
        os: ["ubuntu-latest"]
        python-version: ["3.10", "3.11"]
-        with-process: ["v3.1.0", "process_disabled"]
+        with-process: ["main", "process_disabled"]


Change me back

je-cook · 2025-01-31T08:46:21Z

.github/workflows/actions/build/action.yml

@@ -24,6 +24,7 @@ runs:
        repository: "Fusion-Power-Plant-Framework/bluemira-private-data"
        ssh-key: ${{ inputs.bm-private-data-key }}
        path: "./bluemira-private-data"
+        ref: je-cook/process_develop


sonarqubecloud · 2025-04-24T15:18:21Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
9.3% Duplication on New Code

See analysis details on SonarQube Cloud

…manner.

…e printed message clearer; cleaned up the module docstring.

… use.

…me commands from the manual renaming section of the output)

…ed per process renaming PR.

sonarqubecloud · 2025-07-21T13:12:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
9.4% Duplication on New Code

See analysis details on SonarQube Cloud

je-cook added enhancement New feature or request codes Tasks relating to integration of external codes upstream Issues related to upstream dependencies labels Oct 11, 2024

je-cook requested a review from a team as a code owner October 11, 2024 15:15

je-cook marked this pull request as draft October 11, 2024 15:15

je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from f4c9acc to 346a6f1 Compare October 22, 2024 12:35

je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from c349301 to f61bf02 Compare November 6, 2024 15:15

je-cook mentioned this pull request Nov 7, 2024

:3260 update the fusion reactions section of the plasma docs to full account for all models and details ukaea/PROCESS#3345

Merged

5 tasks

je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from 38c12bd to f635b7c Compare November 18, 2024 12:51

je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from 577b1c2 to 8b60a2e Compare December 2, 2024 11:59

je-cook mentioned this pull request Dec 4, 2024

Update _plotting.py to plot radial build from MFILE for process versi… #3728

Closed

3 tasks

je-cook force-pushed the develop branch from 2672dd0 to 4af381e Compare December 4, 2024 11:09

je-cook force-pushed the je-cook/process_develop branch from d28b570 to 259f809 Compare December 6, 2024 09:26

je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from eeada7e to 1481cee Compare January 8, 2025 09:53

je-cook force-pushed the je-cook/process_develop branch from 559f788 to b957845 Compare January 31, 2025 08:19

je-cook commented Jan 31, 2025

View reviewed changes

je-cook force-pushed the je-cook/process_develop branch 5 times, most recently from b3f74bc to 89adf0d Compare February 10, 2025 09:40

👽️ Variable name changes

5186719

je-cook force-pushed the je-cook/process_develop branch from a3271ad to b0fe7af Compare May 28, 2025 09:44

👽️ >apr 24th < may 25th process

9f9e2ab

je-cook force-pushed the je-cook/process_develop branch from b0fe7af to 1d73992 Compare May 29, 2025 10:21

je-cook and others added 10 commits May 29, 2025 13:11

👽️ Casthi -> dr_tf_plasma_case

7c09c50

🎨 More changes

5efaf28

🎨 More changes

25a37ae

🎨 More changes

f4c6224

Process #3670

c16d542

Process #3670 (added the four missed changes back in)

10c6cef

Wrote a script to help update process' variables in a semi-automatic …

fa14239

…manner.

Added docs to the script, and fixed the grep issue.

e449e21

Reduced the complexity of the process variable update script; made th…

2e5d79d

…e printed message clearer; cleaned up the module docstring.

Process #3672

b0acd31

je-cook force-pushed the je-cook/process_develop branch from ff75156 to 6a86f11 Compare June 5, 2025 15:54

je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from bc45d82 to 1a737bc Compare June 24, 2025 07:48

OceanNuclear added 5 commits June 25, 2025 10:08

Slight update to script update_process_variable.py to improve ease of…

269bc1f

… use.

Process #3685

e1a4b94

Made update_process_variable.py quicker to use (can copy and paste so…

f673032

…me commands from the manual renaming section of the output)

Made update_process_variable.py quicker to use (can copy and paste so…

b784ccc

…me commands from the manual renaming section of the output)

PROCESS #3677

722ccf6

je-cook force-pushed the je-cook/process_develop branch 2 times, most recently from dc70504 to 722ccf6 Compare June 30, 2025 14:59

OceanNuclear added 5 commits July 2, 2025 14:24

Process #3700

5a1a4d4

Updated the script further to reduce the amount of manual work requir…

234634c

…ed per process renaming PR.

PROCESS #3705

6836687

PROCESS #3706

e4334d9

PROCESS #3706 corrections

1c8b0b0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

👽️ PROCESS develop api changes #3636

👽️ PROCESS develop api changes #3636

Uh oh!

je-cook commented Oct 11, 2024 •

edited

Loading

Uh oh!

codecov bot commented Oct 11, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Nov 25, 2024 •

edited

Loading

On collect

On collect

On runtest

Uh oh!

je-cook Jan 31, 2025

Uh oh!

je-cook Jan 31, 2025

Uh oh!

sonarqubecloud bot commented Apr 24, 2025

Uh oh!

sonarqubecloud bot commented Jul 21, 2025

Uh oh!

Uh oh!

👽️ PROCESS develop api changes #3636

Are you sure you want to change the base?

👽️ PROCESS develop api changes #3636

Uh oh!

Conversation

je-cook commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Interface Changes

Checklist

Uh oh!

codecov bot commented Oct 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warning Report

On collect

On collect

On runtest

Uh oh!

je-cook Jan 31, 2025

Choose a reason for hiding this comment

Uh oh!

je-cook Jan 31, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 24, 2025

Quality Gate passed

Uh oh!

sonarqubecloud bot commented Jul 21, 2025

Quality Gate passed

Uh oh!

Uh oh!

je-cook commented Oct 11, 2024 •

edited

Loading

codecov bot commented Oct 11, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading