Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select fs for sh fit metric #3642

Conversation

geograham
Copy link
Contributor

Description

Added an option to choose a flux surface with a given normalised flux, rather than the LCFS, for the spherical harmonic constraints. LCFS is still default.

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass pre-commit run --from-ref develop --to-ref HEAD
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@geograham geograham requested a review from a team as a code owner October 16, 2024 10:59
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.13%. Comparing base (811471d) to head (7e1887c).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...timisation/harmonics/harmonics_approx_functions.py 52.63% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3642      +/-   ##
===========================================
- Coverage    76.37%   76.13%   -0.25%     
===========================================
  Files          230      230              
  Lines        26710    26763      +53     
===========================================
- Hits         20401    20375      -26     
- Misses        6309     6388      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@je-cook je-cook added the equilibria Tasks relating to the equilibria module label Oct 16, 2024
@je-cook je-cook enabled auto-merge (squash) October 16, 2024 14:28
@je-cook je-cook self-assigned this Oct 16, 2024
@geograham geograham requested a review from a team as a code owner October 16, 2024 14:41
Copy link

sonarcloud bot commented Oct 16, 2024

@je-cook je-cook merged commit 41ec8d8 into Fusion-Power-Plant-Framework:develop Oct 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
equilibria Tasks relating to the equilibria module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants