Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(messages.properties): Contact Support messages #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aaron-Ritter
Copy link
Contributor

This addresses the Contact Support messages issue mentioned in FusionAuth/fusionauth-issues#2251

We standardized all the messages to a single one Please contact your support for assistance. (German Bitte wenden Sie sich an Ihren Support, um Unterstützung zu erhalten.), which is generic enough to be correct in almost all cases, and helps an easy search and replace throughout the whole localization file if needed.

@Aaron-Ritter
Copy link
Contributor Author

@mooreds

@mooreds
Copy link
Contributor

mooreds commented Aug 5, 2023

Hi Aaron, I've been struggling a bit with how to fix these, since it's not just a question of merging them, unfortunately. I have to also:

  • upstream the English changes (and wait for a new release)
  • consider how to deal with all the other languages that have been localized.

Thanks for the ping, but I'm still thinking on the best way to do this.

@Aaron-Ritter
Copy link
Contributor Author

Hi Dan,

Thanks a lot for the update!

Sorry for the additional ping I wasn't sure if you had a look through all of the different PR so i made sure to add you by comment as i cant assign a reviewer.

Some of the PR i updated all other languages i was sure based on different sources but always at least German. It's something i wasn't sure either, and it looks like for some languages it follows the recommendation on how English should be updated already.

Aaron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants