Simplified refurb in CI after #196 fixed mypy config#214
Merged
jamesbraza merged 2 commits intomainfrom Mar 11, 2025
Merged
Conversation
There was a problem hiding this comment.
PR Overview
This PR simplifies the CI refurbishment process by reducing multiple refurb commands into a single command and adjusting the retry configuration for asynchronous HTTP requests.
- Simplifies refurb command execution in the CI workflow
- Adds a linter suppression comment in a test file
- Removes the initial delay parameter from the exponential jitter function in the retry decorator
Reviewed Changes
| File | Description |
|---|---|
| packages/lfrqa/tests/test_lfrqa_env.py | Adds a noqa comment to suppress a specific linting error |
| .github/workflows/tests.yml | Simplifies the refurb command execution in the CI pipeline |
| packages/hotpotqa/src/aviary/envs/hotpotqa/env.py | Removes the initial delay from the wait_exponential_jitter setting |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/tests.yml:64
- Ensure that the simplified 'uv run refurb .' command still covers all the necessary directories and tests previously handled by the multi-step commands. Verify that no refurb operations are inadvertently skipped.
- run: uv run refurb .
packages/hotpotqa/src/aviary/envs/hotpotqa/env.py:51
- Verify that removing the initial=1 parameter from wait_exponential_jitter does not alter the intended retry timing behavior. If the initial delay is critical to spreading out requests, consider reinstating it with the appropriate value.
@retry(stop=stop_after_attempt(2), wait=wait_exponential_jitter(max=4))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized this today, and it's awesome