Skip to content

Simplified refurb in CI after #196 fixed mypy config#214

Merged
jamesbraza merged 2 commits intomainfrom
better-refurb
Mar 11, 2025
Merged

Simplified refurb in CI after #196 fixed mypy config#214
jamesbraza merged 2 commits intomainfrom
better-refurb

Conversation

@jamesbraza
Copy link
Collaborator

I realized this today, and it's awesome

@jamesbraza jamesbraza added the enhancement New feature or request label Mar 11, 2025
@jamesbraza jamesbraza self-assigned this Mar 11, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 11, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR simplifies the CI refurbishment process by reducing multiple refurb commands into a single command and adjusting the retry configuration for asynchronous HTTP requests.

  • Simplifies refurb command execution in the CI workflow
  • Adds a linter suppression comment in a test file
  • Removes the initial delay parameter from the exponential jitter function in the retry decorator

Reviewed Changes

File Description
packages/lfrqa/tests/test_lfrqa_env.py Adds a noqa comment to suppress a specific linting error
.github/workflows/tests.yml Simplifies the refurb command execution in the CI pipeline
packages/hotpotqa/src/aviary/envs/hotpotqa/env.py Removes the initial delay from the wait_exponential_jitter setting

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/tests.yml:64

  • Ensure that the simplified 'uv run refurb .' command still covers all the necessary directories and tests previously handled by the multi-step commands. Verify that no refurb operations are inadvertently skipped.
      - run: uv run refurb .

packages/hotpotqa/src/aviary/envs/hotpotqa/env.py:51

  • Verify that removing the initial=1 parameter from wait_exponential_jitter does not alter the intended retry timing behavior. If the initial delay is critical to spreading out requests, consider reinstating it with the appropriate value.
@retry(stop=stop_after_attempt(2), wait=wait_exponential_jitter(max=4))

Copy link
Collaborator

@maykcaldas maykcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@jamesbraza jamesbraza merged commit 348a059 into main Mar 11, 2025
6 checks passed
@jamesbraza jamesbraza deleted the better-refurb branch March 11, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants