Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] README example import typo #10

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[Fix] README example import typo #10

merged 1 commit into from
Sep 9, 2024

Conversation

albertbou92
Copy link
Contributor

README example import typo

jamesbraza
jamesbraza approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future work would be adding a CI check that our README code samples actually run

@albertbou92 albertbou92 merged commit 642e128 into main Sep 9, 2024
5 checks passed
@albertbou92 albertbou92 deleted the readme_example_fix2 branch September 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbraza jamesbraza jamesbraza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertbou92 @jamesbraza