Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a few pytest filterwarnings for clean test logs #27

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

jamesbraza
Copy link
Collaborator

Cleaning up our logs a bit.

@jamesbraza jamesbraza added the bug Something isn't working label Sep 12, 2024
@jamesbraza jamesbraza self-assigned this Sep 12, 2024
@@ -134,7 +135,10 @@ def __init__(self, **kwargs):

async def _add_to_index(self, embedding: np.ndarray) -> int:
async with self.safe_access_index() as index:
return int(index.add(len(self.memories), embedding))
added_value = cast(
npt.NDArray[np.int_], index.add(len(self.memories), embedding)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's informing mypy, in general this numpy deprecation makes the code look more complex haha

@jamesbraza jamesbraza merged commit ff9c551 into main Sep 12, 2024
6 checks passed
@jamesbraza jamesbraza deleted the pytest-filtering branch September 12, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants