Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove transformers and make torch optional #8

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Remove transformers and make torch optional #8

merged 2 commits into from
Sep 6, 2024

Conversation

sidnarayanan
Copy link
Collaborator

Slimming down dependencies by:

  • Removing transformers
  • Making torch a lazy import

To install torch dependencies, specify the extra ldp[nn].

jamesbraza
jamesbraza reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add torch to pre-commit's mypy

jamesbraza
jamesbraza approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind I was wrong on torch thing in pre-commit. LGTM

@sidnarayanan sidnarayanan merged commit 09ae233 into main Sep 6, 2024
4 checks passed
@sidnarayanan sidnarayanan deleted the optional-torch branch September 6, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbraza jamesbraza jamesbraza approved these changes

@whitead whitead Awaiting requested review from whitead

@Ryan-Rhys Ryan-Rhys Awaiting requested review from Ryan-Rhys

@albertbou92 albertbou92 Awaiting requested review from albertbou92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidnarayanan @jamesbraza