-
Notifications
You must be signed in to change notification settings - Fork 778
Modernized and streamlined default LLMs #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes default LLM selections by:
- Migrating from OpenAI's GPT-4 to Anthropic's Claude Sonnet 4-5 as the default model
- Removing hardcoded model defaults in function signatures to rely on centralized settings
- Updating test cassettes to reflect the model changes
Reviewed Changes
Copilot reviewed 5 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/cassettes/test_partly_embedded_texts[True].yaml | Updated test cassette reflecting API interactions with the new default model and updated library versions |
| src/paperqa/settings.py | Changed default LLM from gpt-4o-2024-11-20 to claude-sonnet-4-5-20250929 for agent_llm, llm, and summary_llm; removed unused CommonLLMNames import |
| src/paperqa/agents/models.py | Removed hardcoded default model from get_summary method signature |
| src/paperqa/agents/helpers.py | Made llm parameter required by removing default value and reordering parameters in litellm_get_search_query |
| README.md | Updated documentation to reflect new default models |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
For simplicity, it would be nice to only require one provider. If we change to Anthropic a user needs OpenAI keys and Anthropic keys, right? Because if the embeddings? |
e254a31 to
41543f3
Compare
Yeah makes sense, so I just updated to GPT-5. Why I hadn't originally was, GPT-5 requires updating our default |
41543f3 to
c672891
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for this!
This PR:
SettingsAnthropicOpenAI modelPreviously we used
gpt-4o-2024-11-20for our models. From https://platform.openai.com/docs/models/gpt-4o, https://platform.openai.com/docs/models/gpt-5, and https://docs.claude.com/en/docs/about-claude/models/overview as of 10/20/2025:gpt-4o-2024-11-20gpt-5-2025-08-07claude-sonnet-4-5-20250929