fake agent allowing timeouts or exceptions,
#672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
whitead
reviewed
Nov 8, 2024
paperqa/agents/main.py
Outdated
Comment on lines
362
to
364
| if traj.steps[-1].truncated: | ||
| nonlocal status | ||
| status = AgentStatus.TRUNCATED |
There was a problem hiding this comment.
This is confusing - can you just return status in rollout? This modification is like three levels deep and I'm actually unclear on if it always works
There was a problem hiding this comment.
Believe it or not, locally I have this exact change in the works
There was a problem hiding this comment.
Okay, done. Good to see we are both still thinking
jamesbraza
force-pushed
the
standard-rollouts
branch
from
50f53ce
to
a0771aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to read diff: https://github.com/Future-House/paper-qa/compare/standard-rollouts?expand=1&w=1
This PR:
run_with_timeout_failurethat runs a rollout withAgentStatus.TRUNCATED(timeout) orAgentStatus.FAIL(Exception) supportAgentStatus.TRUNCATEDsupport for the LDP agent runner