Optional AnswerSetting.max_answer_attempts to allow a new unsure branch
#673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
jamesbraza
commented
Nov 8, 2024
| agent=SimpleAgent(), | ||
| dataset=dataset, | ||
| callbacks=[storage_callback], | ||
| ) | ||
| await evaluator.evaluate() | ||
| for traj in storage_callback.eval_trajectories: | ||
| assert not traj.failed | ||
| assert traj.done |
There was a problem hiding this comment.
This specific assertion will not pass before this PR without this new setting
jamesbraza
force-pushed
the
max-answer-attempts
branch
from
8399679
to
283154a
Compare
mskarlin
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in an optional
AnswerSetting.max_answer_attemptsso we can declare ourselves as unsure if we attemptgen_answertoo many times, with test coverage.To do so, it tracks a tool names used in environment state as
tool_history