Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed tool_names validation for gen_answer being present #685

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

jamesbraza
Copy link
Collaborator

@jamesbraza jamesbraza commented Nov 14, 2024

If any of the tools are excluded, PaperQA will not function. They all play a distinct and required role (paper_search to get new papers, gather_evidence to get relevant evidence, and gen_answer for answering), and none are optional.

We can either:

  • Validate for all required tools, leading to an explicit failure
    • Perhaps in the future when we add the citation traversal tool, this tool will be optional.
  • Validate for none of them, leading to an implicit failure, as if any tools are unspecified the agent will either get truncated or fail

We can YAGNI on the first route, so this PR takes the second route as suggested in this PR comment: #684 (comment)

@jamesbraza jamesbraza added the enhancement New feature or request label Nov 14, 2024
@jamesbraza jamesbraza self-assigned this Nov 14, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 14, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 14, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 14, 2024
Copy link
Collaborator

@mskarlin mskarlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed w your logic here

@jamesbraza jamesbraza merged commit 05cd33c into main Nov 14, 2024
5 checks passed
@jamesbraza jamesbraza deleted the removing-complete-check branch November 14, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants