Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update add-certificates-to-load-balancer.md #1559

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

kostichs
Copy link
Contributor

@kostichs kostichs commented Feb 3, 2025

No description provided.

Copy link
Collaborator

@milileitnercohen milileitnercohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please action comment

@@ -30,7 +30,7 @@ You can add multiple certificates to listeners that use the Terminated HTTPS and

### 1. Add certificates to the Secrets Manager

To get started, you need to add the required certificates to Gcore Secrets Manager. If you don’t have any certificates created, follow the instructions from this guide: <a href="https://gcore.com/docs/cloud/secrets-manager/upload-a-pkcs12-file" target="_blank">Upload a PKCS12 file</a>.
To get started, you need to add the required certificates to Gcore Secrets Manager. If you don’t have any certificates created, follow the instructions in this guide: <a href="https://gcore.com/docs/cloud/secrets-manager/upload-a-pkcs12-file" target="_blank">Configure Secrets for HTTPS Load Balancer</a>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never use a direct callout for a link. Instead, try "follow the instructions from our guide on configuring secrets for HTTPS Load Balancers" (bold indicates anchor text)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected in the next commit

@milileitnercohen milileitnercohen merged commit 53badfe into G-Core:main Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants