Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCLOUD2-17747 Support for gpu baremetal and virtual images #184

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

algis-dumbris
Copy link

No description provided.

- Introduced new resource `gcore_gpu_baremetal_image` for managing custom baremetal images
- Added resource creation, read, and deletion functionality
- Implemented comprehensive schema with support for image metadata and configuration options
- Updated provider to include the new baremetal image resource
- Introduced new resource `gcore_gpu_virtual_image` for managing custom virtual GPU images
- Created a base GPU image resource with shared functionality for baremetal and virtual image types
- Updated provider to include the new virtual image resource
- Refactored baremetal image resource to use the new base GPU image implementation
…n details

- Simplified resource implementation by removing verbose logging and detailed method implementations
- Kept core resource definition and schema
- Prepared for potential future base implementation or code cleanup
- Removed unnecessary dependencies like terraform-plugin-docs
- Updated go.sum to reflect dependency changes
- Added a replace directive for gcorelabscloud-go package to use a specific fork
- Updated go.mod to use the latest version of gcorelabscloud-go
- Removed unnecessary dependencies from go.sum
- Simplified module dependencies
@algis-dumbris algis-dumbris force-pushed the feature/gpu-baremetal-images branch from 97c172f to 619e339 Compare February 17, 2025 11:59
- Updated go.mod and go.sum to use the latest version of gcorelabscloud-go
- Removed outdated dependency entries
- Created example Terraform configuration for `gcore_gpu_baremetal_image`
- Created example Terraform configuration for `gcore_gpu_virtual_image`
- Demonstrated usage of GPU image resources with Ubuntu 23.10 cloud image
@algis-dumbris algis-dumbris changed the title Support for gpu baremetal virtual images Support for gpu baremetal and virtual images Feb 18, 2025
Copy link
Contributor

@pedrodeoliveira pedrodeoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add docs for the new resources.

- Replaced Ubuntu 23.10 cloud image with CirrOS 0.4.0 image in GPU baremetal and virtual image examples
- Updated image name and URL for both `gcore_gpu_baremetal_image` and `gcore_gpu_virtual_image` resources
- Updated task extraction method in GPU image resource creation
- Simplified task ID retrieval using new Extract() method
- Improved error handling during task processing
- Created comprehensive documentation for `gcore_gpu_baremetal_image` resource
- Created comprehensive documentation for `gcore_gpu_virtual_image` resource
- Included example usage, argument references, and import instructions for both resources
@algis-dumbris
Copy link
Author

Please add docs for the new resources.

Thanks, I missed that. Now the .md files are in their place.

- Updated documentation for `gcore_gpu_baremetal_image` and `gcore_gpu_virtual_image`
- Reorganized schema section to clearly distinguish between required and optional arguments
- Removed redundant "(Optional)" and "(Required)" labels for improved readability
@pedrodeoliveira pedrodeoliveira changed the title Support for gpu baremetal and virtual images GCLOUD2-17747 Support for gpu baremetal and virtual images Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants