-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCLOUD2-17747 Support for gpu baremetal and virtual images #184
Open
algis-dumbris
wants to merge
12
commits into
master
Choose a base branch
from
feature/gpu-baremetal-images
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+531
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new resource `gcore_gpu_baremetal_image` for managing custom baremetal images - Added resource creation, read, and deletion functionality - Implemented comprehensive schema with support for image metadata and configuration options - Updated provider to include the new baremetal image resource
- Introduced new resource `gcore_gpu_virtual_image` for managing custom virtual GPU images - Created a base GPU image resource with shared functionality for baremetal and virtual image types - Updated provider to include the new virtual image resource - Refactored baremetal image resource to use the new base GPU image implementation
…n details - Simplified resource implementation by removing verbose logging and detailed method implementations - Kept core resource definition and schema - Prepared for potential future base implementation or code cleanup
- Removed unnecessary dependencies like terraform-plugin-docs - Updated go.sum to reflect dependency changes - Added a replace directive for gcorelabscloud-go package to use a specific fork
…ackage" This reverts commit fd7b20d.
- Updated go.mod to use the latest version of gcorelabscloud-go - Removed unnecessary dependencies from go.sum - Simplified module dependencies
97c172f
to
619e339
Compare
- Updated go.mod and go.sum to use the latest version of gcorelabscloud-go - Removed outdated dependency entries
- Created example Terraform configuration for `gcore_gpu_baremetal_image` - Created example Terraform configuration for `gcore_gpu_virtual_image` - Demonstrated usage of GPU image resources with Ubuntu 23.10 cloud image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add docs for the new resources.
- Replaced Ubuntu 23.10 cloud image with CirrOS 0.4.0 image in GPU baremetal and virtual image examples - Updated image name and URL for both `gcore_gpu_baremetal_image` and `gcore_gpu_virtual_image` resources
- Updated task extraction method in GPU image resource creation - Simplified task ID retrieval using new Extract() method - Improved error handling during task processing
- Created comprehensive documentation for `gcore_gpu_baremetal_image` resource - Created comprehensive documentation for `gcore_gpu_virtual_image` resource - Included example usage, argument references, and import instructions for both resources
Thanks, I missed that. Now the .md files are in their place. |
- Updated documentation for `gcore_gpu_baremetal_image` and `gcore_gpu_virtual_image` - Reorganized schema section to clearly distinguish between required and optional arguments - Removed redundant "(Optional)" and "(Required)" labels for improved readability
pedrodeoliveira
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.