CDI-468: add origin shielding #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-sharonov
requested review from
andrei-lukyanchyk,
freenoth and
MarianaStrix
andrei-lukyanchyk
requested changes
Feb 22, 2024
go.mod
Outdated
| @@ -50,7 +50,6 @@ require ( | |||
| github.com/hashicorp/hcl/v2 v2.17.0 // indirect | |||
| github.com/hashicorp/logutils v1.0.0 // indirect | |||
| github.com/hashicorp/terraform-json v0.21.0 // indirect | |||
| github.com/hashicorp/terraform-plugin-docs v0.18.0 // indirect | |||
There was a problem hiding this comment.
Why did you decide to remove this plugin?
There was a problem hiding this comment.
return back, ide show it isn't used and remove it each time.
# Conflicts: # go.mod # go.sum
# Conflicts: # gcore/provider.go # go.mod # go.sum
andrei-lukyanchyk
requested changes
Mar 5, 2024
andrei-lukyanchyk
approved these changes
Mar 6, 2024
freenoth
previously requested changes
Mar 13, 2024
anton-sharonov
dismissed
freenoth’s stale review
comment fixed, conversation resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.