Add positive test for String.IndexOf.

.gitattributes

@@ -4,4 +4,5 @@
 # Always use lf for F# files
 *.fs text eol=lf
 *.fsx text eol=lf
-*.fsi text eol=lf
+*.fsi text eol=lf
+*.expected text eol=lf

src/FSharp.Analyzers/Codes.fs

@@ -5,3 +5,6 @@ let StringEndsWith = "GRA-001"
 
 [<Literal>]
 let StringStartsWith = "GRA-002"
+
+[<Literal>]
+let StringIndexOf = "GRA-003"

src/FSharp.Analyzers/StringAnalyzers.fs

@@ -140,9 +140,10 @@ module StringAnalyzers =
             else
                 fsharpType.GenericArguments |> Seq.map visit |> String.concat " -> "
 
-        visit mfv.FullType = expectedSignature
+        let actualSignature = visit mfv.FullType
+        actualSignature = expectedSignature
 
-    [<CliAnalyzer>]
+    [<CliAnalyzer "String.EndsWith Analyzer">]
     let endsWithAnalyzer (ctx : CliContext) : Async<Message list> =
         invalidStringFunctionUseAnalyzer
             "EndsWith"
@@ -157,7 +158,7 @@ module StringAnalyzers =
             | _ -> false)
             (hasMatchingSignature "System.String -> System.Boolean")
 
-    [<CliAnalyzer>]
+    [<CliAnalyzer "String.StartsWith Analyzer">]
     let startsWithAnalyzer (ctx : CliContext) : Async<Message list> =
         invalidStringFunctionUseAnalyzer
             "StartsWith"
@@ -171,3 +172,18 @@ module StringAnalyzers =
             | SingleStringArgumentExpr _ -> true
             | _ -> false)
             (hasMatchingSignature "System.String -> System.Boolean")
+
+    [<CliAnalyzer "String.IndexOf Analyzer">]
+    let indexOfAnalyzer (ctx : CliContext) : Async<Message list> =
+        invalidStringFunctionUseAnalyzer
+            "IndexOf"
+            Codes.StringIndexOf
+            "The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload."
+            Warning
+            ctx.SourceText
+            ctx.ParseFileResults.ParseTree
+            ctx.CheckFileResults
+            (function
+            | SingleStringArgumentExpr _ -> true
+            | _ -> false)
+            (hasMatchingSignature "System.String -> System.Int32")

src/FSharp.Analyzers/StringAnalyzers.fsi

@@ -3,8 +3,11 @@ namespace ``G-Research``.FSharp.Analyzers
 open FSharp.Analyzers.SDK
 
 module StringAnalyzers =
-    [<CliAnalyzer>]
+    [<CliAnalyzer "String.EndsWith Analyzer">]
     val endsWithAnalyzer : ctx : CliContext -> Async<Message list>
 
-    [<CliAnalyzer>]
+    [<CliAnalyzer "String.StartsWith Analyzer">]
     val startsWithAnalyzer : ctx : CliContext -> Async<Message list>
+
+    [<CliAnalyzer "String.IndexOf Analyzer">]
+    val indexOfAnalyzer : ctx : CliContext -> Async<Message list>

tests/data/string/indexof/Constant String - Single Argument.fs

@@ -0,0 +1 @@
+"foo".IndexOf("p")

tests/data/string/indexof/Constant String - Single Argument.fs.expected

@@ -0,0 +1 @@
+GRA-003 | Warning | (1,6 - 1,13) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/Function call - Single Argument.fs

@@ -0,0 +1,2 @@
+let f () = "f"
+"g".IndexOf(f())

tests/data/string/indexof/Function call - Single Argument.fs.expected

@@ -0,0 +1 @@
+GRA-003 | Warning | (2,4 - 2,11) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/Prefixed Value - Single Argument.fs

@@ -0,0 +1,4 @@
+module A =
+    let b = "b"
+
+A.b.IndexOf("b")

tests/data/string/indexof/Prefixed Value - Single Argument.fs.expected

@@ -0,0 +1 @@
+GRA-003 | Warning | (4,4 - 4,11) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.

tests/data/string/indexof/Value - Single Argument.fs

@@ -0,0 +1,2 @@
+let a = "a"
+a.IndexOf("a")

tests/data/string/indexof/Value - Single Argument.fs.expected

@@ -0,0 +1 @@
+GRA-003 | Warning | (2,2 - 2,9) | The usage of String.IndexOf with a single string argument is discouraged. Signal your intention explicitly by calling an overload.