JsonSerializerOptions analyzer #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dawedawe
commented
Sep 20, 2023
dawedawe
commented
- add a JsonSerializerOptions analyzer
- refactor testing code
- add tests for new analyzer
- refactor testing code - add tests for new analyzer
nojaf
reviewed
Sep 20, 2023
| module JsonSerializerOptionsAnalyzer = | ||
|
|
||
| [<Literal>] | ||
| let Code = "GRA-002" |
There was a problem hiding this comment.
I think this code thing is going to be a lot of fun.
|
|
||
| match ctx.TypedTree with | ||
| | None -> () | ||
| | Some typedTree -> typedTree.Declarations |> List.iter (visitDeclaration handler) |
There was a problem hiding this comment.
It seems like we have a different take on how we find the information.
In the String analyzers, I went with checking the untyped tree first in order to find invocations. I wonder what the most beneficial way is of doing things.
I genuinely do not know what is best in this case.
Let's discuss this tomorrow maybe.
This reverts commit b4cab32.
…ve different handlers for the various parts of the TAST an analyzer might want to handle.
nojaf
reviewed
Sep 21, 2023
|
good to go in now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.