Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the LoggingTemplateMissingValuesAnalyzer #53

Merged
merged 3 commits into from
Jan 10, 2024
Merged

add the LoggingTemplateMissingValuesAnalyzer #53

merged 3 commits into from
Jan 10, 2024

Conversation

dawedawe
Copy link
Contributor

As discussed here

@dawedawe dawedawe requested a review from nojaf January 10, 2024 10:34
nojaf
nojaf previously approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work.

What happens when you have something like logger.LogInformation("Foo {one} {two}", [| box 1; box 2 |]).

tests/data/loggingtemplatemissingvalues/Warnings for one missing.fs.expected Outdated
@@ -0,0 +1 @@
GRA-LOGTEMPLMISSVALS-001 | Warning | (9,8 - 9,67) | The given values in your call to ILogger.Log{Warning, Error, ...} don't match the expected templated args. | []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: you can probably use the name of the used function in the message?

@dawedawe
Copy link
Contributor Author

Solid work.

What happens when you have something like logger.LogInformation("Foo {one} {two}", [| box 1; box 2 |]).

Thanks.
That's handled correctly but I can add a test.

nojaf
nojaf approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dawedawe dawedawe merged commit 995bca0 into main Jan 10, 2024
1 check passed
@dawedawe dawedawe deleted the add_loggingtemplatemissingvaluesanalyzer branch January 10, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawedawe @nojaf