Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lint check #249

Merged
merged 9 commits into from
Jun 17, 2024
Merged

Enable Lint check #249

merged 9 commits into from
Jun 17, 2024

Conversation

ljubon
Copy link
Contributor

@ljubon ljubon commented Jan 31, 2024

Checklist before submitting

  • Did you read the contributing guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?

Description

The goal of this change is to enable linting as required check for the CI
example run: https://github.com/ljubon/spark-dgraph-connector/actions/runs/6946230885/job/18897234201

Resolves https://github.com/G-Research/oss-portfolio-maturity/issues/369.

Review process for approval

  1. All tests and other checks must succeed.
  2. At least one core contributors must review and approve.
  3. If a core contributor requests changes, they must be addressed.

@EnricoMi
Copy link
Collaborator

I'd prefer to do this the same way we did in G-Research/spark-extension#201 and G-Research/spark-extension#212.

Copy link

github-actions bot commented May 20, 2024

Test Results

 2 753 files   -   243   2 753 suites   - 243   49m 41s ⏱️ - 2m 17s
   486 tests ±    0     485 ✅ ±    0   1 💤 ±0  0 ❌ ±0 
39 807 runs   - 3 277  39 719 ✅  - 3 269  88 💤  - 8  0 ❌ ±0 

Results for commit f259d93. ± Comparison against base commit 09dacbf.

♻️ This comment has been updated with latest results.

@ljubon
Copy link
Contributor Author

ljubon commented May 20, 2024

I'd prefer to do this the same way we did in G-Research/spark-extension#201 and G-Research/spark-extension#212.

In latest commit, i've applied changes from suggested PRs/commits:

p.s format is not applied, so it's expected that action Linting is failing - let me know if you want me to commit to this PR formated code which will affect the files in src/

@ljubon ljubon requested a review from EnricoMi May 31, 2024 10:57
@EnricoMi
Copy link
Collaborator

EnricoMi commented Jun 5, 2024

let me know if you want me to commit to this PR formated code which will affect the files in src/

applied in #264

@ljubon ljubon requested a review from EnricoMi June 11, 2024 11:15
@EnricoMi EnricoMi closed this Jun 14, 2024
@EnricoMi EnricoMi reopened this Jun 14, 2024
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi merged commit d4ca49c into G-Research:main Jun 17, 2024
161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants