Feat: Adding third party stakes using the address of the user

[ogarciarevett]

This pull request introduces significant changes to the staking contract system, primarily focused on enhancing the staking functionality and updating the test cases accordingly. The most important changes include the addition of a new interface for staking operations, modifications to the staking functions to include a positionHolder parameter, and updates to the test cases to reflect these changes.

Enhancements to Staking Functionality:

• web3/contracts/interfaces/IStaker.sol: Added a new interface IStaker that defines various staking-related functions and events, including createPool, updatePoolConfiguration, stakeNative, stakeERC20, stakeERC721, stakeERC1155, initiateUnstake, and unstake.

Modifications to Staking Functions:

• web3/contracts/staking/Staker.sol: Updated the staking functions (stakeNative, stakeERC20, stakeERC721, stakeERC1155) to include a positionHolder parameter, allowing the specification of the position holder address. This change also includes updates to the corresponding _mint and emit statements to use positionHolder instead of msg.sender. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Updates to Access Control:

• web3/contracts/staking/Staker.sol: Modified the initiateUnstake and unstake functions to allow the pool administrator to initiate and complete unstaking operations, in addition to the position owner. [1] [2] [3]

Test Case Updates:

• web3/test/Staker.test.1.ts: Updated the test cases to include the positionHolder parameter in the staking function calls, ensuring that the tests reflect the new functionality. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Miscellaneous:

• web3/contracts/mock/tokens.sol: Added SPDX license identifier and updated the Solidity version.
• web3/package.json: Added the package name @game7/protocol.

[octane-security-app-dev]

Summary by Octane

New Contracts

• IStaker.sol: A comprehensive staking smart contract interface facilitating pool creation, configuration, staking of various tokens (Native, ERC20, ERC721, ERC1155), and managing positions with associated events for tracking key actions.

Updated Contracts

• tokens.sol: Updated to allow compatibility with Solidity version 0.8.24.
• Staker.sol: The smart contract now allows staking operations to specify a different holder for the position tokens and permits pool administrators to initiate or complete unstaking on behalf of position owners.

---

🔗 Commit Hash: d298001

[octane-security-app-dev]

Overview

Vulnerabilities found:	1
Severity breakdown:	1 High

Detailed findings

web3/contracts/staking/Staker.sol

• Review potential Ether or Token Leaking issue that is exposed in the unstake function

---

🔗 Commit Hash: d298001
🛡️ Octane Dashboard: All vulnerabilities

[zomglings]

Left several questions.

[zomglings]

Left some comments.

[zomglings]

Two small changes on emission of Unstaked and UnstakeInitiated events.

[zomglings]

lgtm

(pending event checks for unstake and initiateUnstake in the new tests)

@ogarciarevett feel free to merge once you've added those tests. Thanks for the contribution.

[zomglings]

lgtm