Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for same-device flow #32

Merged
merged 6 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,18 @@
![jest workflow](https://github.com/GAIA-X4PLC-AAD/ssi-to-oidc-bridge/actions/workflows/node.js.yml/badge.svg)
![playwright workflow](https://github.com/GAIA-X4PLC-AAD/ssi-to-oidc-bridge/actions/workflows/playwright.yml/badge.svg)

<!-- prettier-ignore -->
> [!WARNING]
> This repository is intended for prototyping and as a reference
> implementation. At this time, no security guarantees can be given.

<!-- prettier-ignore -->
> [!NOTE]
> A preprint of our paper providing more background information is
> available [on arXiv](https://arxiv.org/abs/2401.09488). While it is slightly
> outdated now, it provides a good introduction.

<!-- prettier-ignore -->
> [!NOTE]
> This software artifact was originally intended to support only Gaia-X
> Participant Credentials. It has since evolved to be fully configurable for
Expand Down Expand Up @@ -151,6 +154,7 @@ prototyping an OIDC client service you are developing. Note that running a full
deployment requires the same steps, but instead of using a tool like `ngrok`, a
proper domain has to be set up.

<!-- prettier-ignore -->
> [!IMPORTANT]
> You need to use a tool like ngrok for testing so your smartphone
> wallet can access the vclogin backend. However, it can lead to issues with
Expand Down Expand Up @@ -178,6 +182,7 @@ proper domain has to be set up.

To validate the running bridge with a simple OIDC client:

<!-- prettier-ignore -->
> [!NOTE]
> You might run into a "Permisson denied" issue when running the shell
> script `./test_client.sh`. You need to mark the file as executable using
Expand All @@ -196,6 +201,7 @@ To validate the running bridge with a simple OIDC client:
9. end up at `http://localhost:9010/callback` with metadata about the login
being displayed

<!-- prettier-ignore -->
> [!TIP]
> If you want to understand what the wallet is doing in the exchange, go
> to settings and toggle on "Developer Mode". After scanning a QR code, the
Expand Down
4 changes: 2 additions & 2 deletions vclogin/config/ory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: MIT
*/

import { Configuration, V0alpha2Api } from "@ory/client";
import { Configuration, OAuth2ApiFactory } from "@ory/hydra-client";

const baseOptions: any = {};

Expand All @@ -17,6 +17,6 @@ const configuration = new Configuration({
baseOptions,
});

const hydraAdmin = new V0alpha2Api(configuration);
const hydraAdmin = OAuth2ApiFactory(configuration);

export { hydraAdmin };
Loading
Loading