🧪 MissingSkills Jest Test Broken

[petertgiles]

🧪 Tests

The "should ignore added skills with empty experienceSkillRecords detail field" test has broken with the upgrade to Faker V8. I think there were some assumptions about how the random data looked that are no longer valid. I spent some time trying to fix it in #7481 but gave up after a while.

✅ Acceptance Criteria

• Test reliably passes with Faker at V8.

[vd1992]

The Storybook also yields clues

[petertgiles]

The Storybook also yields clues

Ooh, that's nice! Yeah, the first assertion that fails is "assert there are four lists" which this clearly shows. I got past that by ensuring there were both technical and behavioural skills seeded. The next assertion was around how many items are in each list and that's when I gave up. 😆 This screenshot is great, though. Super helpful!

[vd1992]

I suggest rewriting the relevant test and story to use more explicitly defined skills and skill families.
The component takes required, optional, and added skills that are random. Which in turn have random skill families which then have randomly set skill categories (behavioural, or technical, or if two skill families might have both).
Too much randomness makes this tricky. Rendering is impacted by required vs optional as well as technical vs behavioural.
And being in sync with the Jest tests using the same input data lets you visualize each test.