[Debt] Bump faker to V8 #7481
Merged
[Debt] Bump faker to V8 #7481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
@esizer Ready to approve? 😆 |
esizer
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Resolves #6702
👋 Introduction
This branch bumps the faker dependency to version 8. Since we're only using the default locale ("EN") I simply removed the
setLocalecalls. I also proactively repointed many of the deprecated method calls.Faker V8 has removed the
uniquehelper from the library. In the Github discussion they linked to a library that factors that functionality out. I added a dependency to it and applied it for skills and skill families.One of the tests is now broken with Faker V8 and I couldn't quickly fix it. I skipped it for now and put issue #7515 on the board for it.
🧪 Testing