Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpdialog - Minimize and Close Buttons #1700

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

simon-leech
Copy link
Contributor

@simon-leech simon-leech commented Nov 12, 2024

Help Dialog Tweak

Description

Added the minimize and close buttons to the help Dialog to help allow the user control over their display. This is required when geometry editing as they may cover the popup on the map canvas.

GitHub Issue

#1699

Type of Change

Please delete options that are not relevant, and select all options that apply.

  • ✅ Bug fix (non-breaking change which fixes an issue)

How have you tested this?

Tested locally.

Testing Checklist

Please delete options that are not relevant, and select all options that apply.

  • ✅ Existing Tests still pass
  • ✅ Updated Existing Tests
  • ✅ Ran locally on my machine

Code Quality Checklist

Please delete options that are not relevant, and select all options that apply.

  • ✅ My code follows the guidelines of XYZ
  • ✅ My code has been commented
  • ✅ Documentation has been updated
  • ✅ New and existing unit tests pass locally with my changes

@simon-leech simon-leech changed the base branch from main to patch November 12, 2024 09:01
Copy link

sonarcloud bot commented Nov 12, 2024

@simon-leech simon-leech changed the title Helpdialog min close Helpdialog - Minimize and Close Buttons Nov 12, 2024
@simon-leech simon-leech added Bug A genuine bug. There must be some form of error exception to work with. v4.12.3 labels Nov 12, 2024
@simon-leech simon-leech linked an issue Nov 12, 2024 that may be closed by this pull request
@simon-leech simon-leech marked this pull request as ready for review November 12, 2024 09:01
@RobAndrewHurst RobAndrewHurst removed the Bug A genuine bug. There must be some form of error exception to work with. label Nov 12, 2024
@RobAndrewHurst RobAndrewHurst merged commit c8dc60c into GEOLYTIX:patch Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HelpDialog needs Minimize and Close Buttons
4 participants