Skip to content

Commit

Permalink
[chore] #219 함수 코드 순서 변경
Browse files Browse the repository at this point in the history
  • Loading branch information
jooyyoo committed Feb 16, 2024
1 parent 2eb3d68 commit e380e13
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 34 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ class LoginNeededDialog(
collectData()
}

private fun initLayout() {
binding.loginNeedType = loginNeededType
}

private fun addListener() {
binding.ivDismiss.setOnClickListener { dismiss() }

Expand All @@ -66,10 +70,6 @@ class LoginNeededDialog(
}
}

private fun initLayout() {
binding.loginNeedType = loginNeededType
}

private fun collectData() {
gpDataSource = GPDataSource(requireContext())
// 카카오 회원 가입, 로그인
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,27 +116,6 @@ class DetailActivity : BindingActivity<ActivityDetailBinding>(R.layout.activity_
}
}

private fun showLoginNeedDialogBookmark() {
LoginNeededDialog(LoginNeededType.LOGIN_NEEDED_BOOKMARK).show(
supportFragmentManager,
"loginNeededDialog"
)
}

private fun showLoginNeedDialogWriteReview() {
LoginNeededDialog(LoginNeededType.LOGIN_NEEDED_WRITE_REVIEW).show(
supportFragmentManager,
"loginNeededDialog"
)
}

private fun showLoginNeedDialogReportReview() {
LoginNeededDialog(LoginNeededType.LOGIN_NEEDED_REPORT_REVIEW).show(
supportFragmentManager,
"loginNeededDialog"
)
}

private fun collectData() {
viewModel.bakeryInfo.flowWithLifecycle(lifecycle).onEach {
it?.let { bakeryInfo ->
Expand Down Expand Up @@ -226,6 +205,27 @@ class DetailActivity : BindingActivity<ActivityDetailBinding>(R.layout.activity_
finish()
}

private fun showLoginNeedDialogBookmark() {
LoginNeededDialog(LoginNeededType.LOGIN_NEEDED_BOOKMARK).show(
supportFragmentManager,
"loginNeededDialog"
)
}

private fun showLoginNeedDialogWriteReview() {
LoginNeededDialog(LoginNeededType.LOGIN_NEEDED_WRITE_REVIEW).show(
supportFragmentManager,
"loginNeededDialog"
)
}

private fun showLoginNeedDialogReportReview() {
LoginNeededDialog(LoginNeededType.LOGIN_NEEDED_REPORT_REVIEW).show(
supportFragmentManager,
"loginNeededDialog"
)
}

companion object {
const val BAKERY_ID = "bakeryId"
const val BAKERY_INFO = "bakeryInfo"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ class HomeFragment : BindingFragment<FragmentHomeBinding>(R.layout.fragment_home
binding.ivHomeFilter.setOnClickListener {
AmplitudeUtils.trackEvent(START_FILTER_HOME)
gpDataSource = GPDataSource(it.context)
if (gpDataSource.userRoleType == UserRoleType.NONE_MEMBER.name) {
if (gpDataSource.userRoleType == UserRoleType.NONE_MEMBER.name)
showLoginNeedDialog()
} else
else
moveToFilter()
}

Expand All @@ -72,13 +72,6 @@ class HomeFragment : BindingFragment<FragmentHomeBinding>(R.layout.fragment_home
}
}

private fun showLoginNeedDialog() {
LoginNeededDialog(LoginNeededType.LOGIN_NEEDED_FILTER).show(
parentFragmentManager,
"loginNeededDialog"
)
}

private fun collectData() {
viewModel.bestBakeryListState.flowWithLifecycle(lifecycle).onEach {
when (it) {
Expand Down Expand Up @@ -141,6 +134,13 @@ class HomeFragment : BindingFragment<FragmentHomeBinding>(R.layout.fragment_home
startActivity(intent)
}

private fun showLoginNeedDialog() {
LoginNeededDialog(LoginNeededType.LOGIN_NEEDED_FILTER).show(
parentFragmentManager,
"loginNeededDialog"
)
}

companion object {
const val BAKERY_ID = "bakeryId"
const val FILTER_INFO = "filterInfo"
Expand Down

0 comments on commit e380e13

Please sign in to comment.