[feat] 자체 로그인 api 연동 #146
Merged
[feat] 자체 로그인 api 연동 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/sopt/geonppang/data/datasource/local/GPDataStore.kt # app/src/main/java/com/sopt/geonppang/data/datasource/remote/AuthDataSource.kt # app/src/main/java/com/sopt/geonppang/data/repository/AuthRepositoryImpl.kt # app/src/main/java/com/sopt/geonppang/data/service/AuthService.kt # app/src/main/java/com/sopt/geonppang/domain/repository/AuthRepository.kt # app/src/main/java/com/sopt/geonppang/presentation/auth/AuthViewModel.kt # app/src/main/java/com/sopt/geonppang/presentation/auth/SignUpNicknameActivity.kt
jihyunniiii
reviewed
Sep 18, 2023
| TODO("Not yet implemented") | ||
| } | ||
|
|
||
| override suspend fun login(responseLogin: RequestLogin): Result<Response<ResponseLogin>> = |
There was a problem hiding this comment.
나중에 말하는 거 까먹을까봐
나중에 여기 네이밍 수정 한 번 플리즈
Dan2dani
approved these changes
Sep 19, 2023
| @@ -26,6 +28,10 @@ class AuthRepositoryImpl @Inject constructor( | |||
| override suspend fun logout(): Result<ResponseLogout> = | |||
| runCatching { authDataSource.logout() } | |||
|
|
|||
| override suspend fun settingNickname(nickName: RequestNicknameSetting): Result<ResponseNickNameSetting> = | |||
| runCatching { authDataSource.settingNickname(nickName) } | |||
| override suspend fun settingNickname(nickName: RequestNicknameSetting): Result<ResponseNickNameSetting> { | |||
| _loginState.value = null | ||
| } | ||
|
|
||
| fun login() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢