-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 자체 로그인 api 연동 #146
[feat] 자체 로그인 api 연동 #146
Conversation
# Conflicts: # app/src/main/java/com/sopt/geonppang/data/datasource/local/GPDataStore.kt # app/src/main/java/com/sopt/geonppang/data/datasource/remote/AuthDataSource.kt # app/src/main/java/com/sopt/geonppang/data/repository/AuthRepositoryImpl.kt # app/src/main/java/com/sopt/geonppang/data/service/AuthService.kt # app/src/main/java/com/sopt/geonppang/domain/repository/AuthRepository.kt # app/src/main/java/com/sopt/geonppang/presentation/auth/AuthViewModel.kt # app/src/main/java/com/sopt/geonppang/presentation/auth/SignUpNicknameActivity.kt
TODO("Not yet implemented") | ||
} | ||
|
||
override suspend fun login(responseLogin: RequestLogin): Result<Response<ResponseLogin>> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 말하는 거 까먹을까봐
나중에 여기 네이밍 수정 한 번 플리즈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 오키염 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 단 거 고쳐주구 머지해주세여
@@ -26,6 +28,10 @@ class AuthRepositoryImpl @Inject constructor( | |||
override suspend fun logout(): Result<ResponseLogout> = | |||
runCatching { authDataSource.logout() } | |||
|
|||
override suspend fun settingNickname(nickName: RequestNicknameSetting): Result<ResponseNickNameSetting> = | |||
runCatching { authDataSource.settingNickname(nickName) } | |||
override suspend fun settingNickname(nickName: RequestNicknameSetting): Result<ResponseNickNameSetting> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거슨 왜 지웠나염,, 흑흑 다시 복구 부탁염
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엥 이거 왜.. 쏴리염
_loginState.value = null | ||
} | ||
|
||
fun login() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로그 다 지워주삼염
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢