[feat] 회원가입 뷰 구현 #16
Merged
[feat] 회원가입 뷰 구현 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/res/values/dimens.xml
Dan2dani
reviewed
Jul 14, 2023
Comment on lines
11
to
12
| class DummyActivity : BindingActivity<ActivityDummyBinding>(R.layout.activity_signup_email) { | ||
| private val viewModel: DummyViewModel by viewModels() |
There was a problem hiding this comment.
그리고 지금보니까 왜 엑티비티들이 하나도 메니페스트에 추가가 안돼있을까용?
| android:id="@+id/img_back_arrow" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginLeft="5dp" | ||
| android:layout_marginTop="34dp" | ||
| android:background="@null" |
There was a problem hiding this comment.
이거 꼭 있어야 하나용?!
첨에 코드리뷰 보고 없앴더니 디자인이랑 달라지더라고여ㅜ
| android:layout_marginTop="34dp" | ||
| android:background="@null" | ||
| android:layout_marginLeft="17dp" |
There was a problem hiding this comment.
android:layout_marginStart="17dp"
로 수정해주세영 그리고 이거 패딩 값이 생겨서 이 마진 값이 아닐거 같긴한뎅 확인 부탁~~~
| @@ -45,25 +45,22 @@ | |||
| android:id="@+id/tv_sign_up_page_number" | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:layout_marginTop="34dp" | |||
| android:layout_marginRight="24dp" | |||
| android:padding="12dp" | |||
There was a problem hiding this comment.
이건 패딩이 없어도 될 거 같은데용~ 터치영역과 관련된 부분이 아니기 때문에!
|
|
||
| <TextView | ||
| android:id="@+id/tv_input_email_phrase" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginLeft="24dp" | ||
| android:layout_marginTop="8dp" | ||
| android:layout_marginTop="20dp" |
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="22dp" | ||
| android:src="@{viewModel.isValidEmail() == true? @drawable/ic_smile : @drawable/ic_tears}" |
| app:layout_constraintTop_toBottomOf="@id/view_bottom_sheet_top" | ||
| tools:src="@drawable/ic_smile" /> | ||
|
|
||
| <androidx.constraintlayout.widget.ConstraintLayout |
There was a problem hiding this comment.
이걸 ConstraintLayout으로 감싼 이유는?!
| android:layout_marginVertical="48dp" | ||
| android:backgroundTint="@color/gray_700" | ||
| android:paddingVertical="18dp" | ||
| android:text="확인" |
| android:textAppearance="@style/TextAppearance.Headline" | ||
| android:textColor="@color/gray_100" | ||
| app:layout_constraintBottom_toBottomOf="parent" | ||
| app:layout_constraintEnd_toEndOf="parent" |
There was a problem hiding this comment.
이렇게 구현할거면 glStart, glEnd는 안쓰는거 같아서 두 개 삭제 해주세용! 여기에만 쓰여서 guideline을 삭제하는게 맞을 듯!
Comment on lines
61
to
68
| private fun checkEmailCondition(): Boolean { | ||
| return isValidEmail.value == true | ||
| } | ||
|
|
||
| private fun checkNicknameCondition(): Boolean { | ||
| return isValidNickname.value == true | ||
| } | ||
|
|
Dan2dani
reviewed
Jul 14, 2023
app/src/main/AndroidManifest.xml
Outdated
| @@ -31,6 +31,22 @@ | |||
| android:exported="false" | |||
| android:screenOrientation="portrait" | |||
| tools:ignore="LockedOrientationActivity" /> | |||
| <activity | |||
app/src/main/AndroidManifest.xml
Outdated
| @@ -31,22 +31,6 @@ | |||
| android:exported="false" | |||
| android:screenOrientation="portrait" | |||
| tools:ignore="LockedOrientationActivity" /> | |||
| <activity | |||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@+id/linear_nickname" /><!--visibility viewModel 만든 후 구현 예정--> | ||
|
|
||
| <com.google.android.material.button.MaterialButton |
There was a problem hiding this comment.
Suggested change
| <com.google.android.material.button.MaterialButton | |
| <com.google.android.material.button.MaterialButton | |
| app:rippleColor="@android:color/transparent" |
| class SignUpViewModel @Inject constructor() : ViewModel() { | ||
| val email = MutableLiveData("") | ||
| val password = MutableLiveData("") | ||
| val password_check = MutableLiveData("") |
There was a problem hiding this comment.
변수명 passwordCheck camelcase 지켜주세요
Comment on lines
72
to
73
| const val PASSWORD_PATTERN = | ||
| "^(?=.*[A-Za-z])(?=.*[0-9])(?=.*[\$@\$!%*#?&.])[A-Za-z[0-9]\$@\$!%*#?&.]{6,12}\$" |
There was a problem hiding this comment.
Suggested change
| const val PASSWORD_PATTERN = | |
| "^(?=.*[A-Za-z])(?=.*[0-9])(?=.*[\$@\$!%*#?&.])[A-Za-z[0-9]\$@\$!%*#?&.]{6,12}\$" | |
| const val PASSWORD_PATTERN = "^(?=.*[A-Za-z\\d])[A-Za-z\\d]{8,}$" |
There was a problem hiding this comment.
나머지 리뷰는 내일 달겠습니다 ㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋㅋ 파업이슈
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/sopt/geonppang/util/binding/BindingAdapter.kt # app/src/main/res/values/dimens.xml # app/src/main/res/values/strings.xml # app/src/main/res/values/themes.xml
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/sopt/geonppang/presentation/review/ReviewWritingActivity.kt # app/src/main/res/values/strings.xml # app/src/main/res/values/themes.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
feat-signup-view.mp4
default.mp4
Uncompleted Tasks 😅
To Reviewers 📢
사랑해 안빵티비들