[feat] 온보딩 엠플리튜드 트래킹 이벤트 코드 심기 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
reviewed
Sep 26, 2023
Comment on lines
187
to
234
| private fun getStringBreadType(breadType: SelectedFilter.BreadType): String { | ||
| val selectedTypes = mutableListOf<String>() | ||
|
|
||
| if (breadType.isGlutenFree) { | ||
| selectedTypes.add(getString(R.string.bread_type_gluten_free_title)) | ||
| } | ||
|
|
||
| if (breadType.isVegan) { | ||
| selectedTypes.add(getString(R.string.bread_type_vegan_title)) | ||
| } | ||
|
|
||
| if (breadType.isNutFree) { | ||
| selectedTypes.add(getString(R.string.bread_type_nut_free_title)) | ||
| } | ||
|
|
||
| if (breadType.isSugarFree) { | ||
| selectedTypes.add(getString(R.string.bread_type_sugar_free_title)) | ||
| } | ||
|
|
||
| if (selectedTypes.isEmpty()) { | ||
| return "" | ||
| } | ||
|
|
||
| return selectedTypes.joinToString(", ") | ||
| } | ||
|
|
||
|
|
||
| private fun getStringIngredientType(ingredientType: SelectedFilter.NutrientType): String { | ||
| val selectedTypes = mutableListOf<String>() | ||
|
|
||
| if (ingredientType.isIngredientOpen) { | ||
| selectedTypes.add(getString(R.string.nutrient_type_ingredient_open)) | ||
| } | ||
|
|
||
| if (ingredientType.isNutrientOpen) { | ||
| selectedTypes.add(getString(R.string.nutrient_type_nutrient_open)) | ||
| } | ||
|
|
||
| if (ingredientType.isNotOpen) { | ||
| selectedTypes.add(getString(R.string.nutrient_type_not_open)) | ||
| } | ||
|
|
||
| if (selectedTypes.isEmpty()) { | ||
| return "" | ||
| } | ||
|
|
||
| return selectedTypes.joinToString(", ") | ||
| } |
There was a problem hiding this comment.
언니 이거 bread type이랑 ingredients type 영어로 값 주라고 되어있지 않아??
이고 그래서 이 함수 안 만들고 그냥 뷰모델에 저장되어 있는 값 거의 바로 주면 될텐데!!
확인 한 번 플리즈!!
There was a problem hiding this comment.
흠냐륑 오키염 ! 영어로 달라고 하고 있네 hehe 머쓱
Comment on lines
44
to
49
| ViewPager2.OnPageChangeCallback() { | ||
| override fun onPageSelected(position: Int) { | ||
| super.onPageSelected(position) | ||
| viewModel.setCurrentPage(position) | ||
| } | ||
| }) | ||
| ViewPager2.OnPageChangeCallback() { | ||
| override fun onPageSelected(position: Int) { | ||
| super.onPageSelected(position) | ||
| viewModel.setCurrentPage(position) | ||
| } | ||
| }) |
There was a problem hiding this comment.
요거 때문에 ktlint 오류 나는 고! 한 번씩 탭 해줘야 함 ㅜㅜ
There was a problem hiding this comment.
헐 지현아 땡큐 이거 계속 복붙했는데도 안돼서 힘들었음 ㅜ
jihyunniiii
reviewed
Sep 27, 2023
Comment on lines
11
to
30
| GLUTENFREE( | ||
| R.string.bread_type_gluten_free_ampl, | ||
| R.string.bread_type_gluten_free_title, | ||
| R.string.bread_type_gluten_free_des | ||
| ), | ||
| VEGAN( | ||
| R.string.bread_type_vegan_ampl, | ||
| R.string.bread_type_vegan_title, | ||
| R.string.bread_type_vegan_des | ||
| ), | ||
| NUTFREE( | ||
| R.string.bread_type_nut_free_ampl, | ||
| R.string.bread_type_nut_free_title, | ||
| R.string.bread_type_nut_free_des | ||
| ), | ||
| SUGARFREE( | ||
| R.string.bread_type_sugar_free_ampl, | ||
| R.string.bread_type_sugar_free_title, | ||
| R.string.bread_type_sugar_free_des, | ||
| ) |
There was a problem hiding this comment.
요거 대문자로 보내도 괜찮다고 해서 따로 string 리소스 추가 안 하고 그냥 저 값만 보내두 됨요! BreadFilterType의 이름!!! 이라구 하나 아무튼 그거 ㅋㅋㅋ ㅜ 나 다른 엠플 붙인 거 그 방식대로 해놨으니까 참고하면 좋을 듯!!
There was a problem hiding this comment.
오 내가 딱 말하려 했는데 ㅋ.ㅋ 대문자로 보내주세얌 ~~
Comment on lines
7
to
20
| @StringRes val amplitudeRes: Int, | ||
| @StringRes val titleRes: Int | ||
| ) { | ||
| NUTRIENT( | ||
| R.string.nutrient_type_nutrient_open_ampl, | ||
| R.string.nutrient_type_nutrient_open | ||
| ), | ||
| INGREDIENT( | ||
| R.string.nutrient_type_ingredient_open_ampl, | ||
| R.string.nutrient_type_ingredient_open | ||
| ), | ||
| NOT( | ||
| R.string.nutrient_type_not_open_ampl, | ||
| R.string.nutrient_type_not_open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢