-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] 온보딩 엠플리튜드 트래킹 이벤트 코드 심기 #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생했삼삼이
private fun getStringBreadType(breadType: SelectedFilter.BreadType): String { | ||
val selectedTypes = mutableListOf<String>() | ||
|
||
if (breadType.isGlutenFree) { | ||
selectedTypes.add(getString(R.string.bread_type_gluten_free_title)) | ||
} | ||
|
||
if (breadType.isVegan) { | ||
selectedTypes.add(getString(R.string.bread_type_vegan_title)) | ||
} | ||
|
||
if (breadType.isNutFree) { | ||
selectedTypes.add(getString(R.string.bread_type_nut_free_title)) | ||
} | ||
|
||
if (breadType.isSugarFree) { | ||
selectedTypes.add(getString(R.string.bread_type_sugar_free_title)) | ||
} | ||
|
||
if (selectedTypes.isEmpty()) { | ||
return "" | ||
} | ||
|
||
return selectedTypes.joinToString(", ") | ||
} | ||
|
||
|
||
private fun getStringIngredientType(ingredientType: SelectedFilter.NutrientType): String { | ||
val selectedTypes = mutableListOf<String>() | ||
|
||
if (ingredientType.isIngredientOpen) { | ||
selectedTypes.add(getString(R.string.nutrient_type_ingredient_open)) | ||
} | ||
|
||
if (ingredientType.isNutrientOpen) { | ||
selectedTypes.add(getString(R.string.nutrient_type_nutrient_open)) | ||
} | ||
|
||
if (ingredientType.isNotOpen) { | ||
selectedTypes.add(getString(R.string.nutrient_type_not_open)) | ||
} | ||
|
||
if (selectedTypes.isEmpty()) { | ||
return "" | ||
} | ||
|
||
return selectedTypes.joinToString(", ") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
언니 이거 bread type이랑 ingredients type 영어로 값 주라고 되어있지 않아??
이고 그래서 이 함수 안 만들고 그냥 뷰모델에 저장되어 있는 값 거의 바로 주면 될텐데!!
확인 한 번 플리즈!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠냐륑 오키염 ! 영어로 달라고 하고 있네 hehe 머쓱
ViewPager2.OnPageChangeCallback() { | ||
override fun onPageSelected(position: Int) { | ||
super.onPageSelected(position) | ||
viewModel.setCurrentPage(position) | ||
} | ||
}) | ||
ViewPager2.OnPageChangeCallback() { | ||
override fun onPageSelected(position: Int) { | ||
super.onPageSelected(position) | ||
viewModel.setCurrentPage(position) | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 때문에 ktlint 오류 나는 고! 한 번씩 탭 해줘야 함 ㅜㅜ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헐 지현아 땡큐 이거 계속 복붙했는데도 안돼서 힘들었음 ㅜ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생했다 윤주ㅃㅏㅇ
GLUTENFREE( | ||
R.string.bread_type_gluten_free_ampl, | ||
R.string.bread_type_gluten_free_title, | ||
R.string.bread_type_gluten_free_des | ||
), | ||
VEGAN( | ||
R.string.bread_type_vegan_ampl, | ||
R.string.bread_type_vegan_title, | ||
R.string.bread_type_vegan_des | ||
), | ||
NUTFREE( | ||
R.string.bread_type_nut_free_ampl, | ||
R.string.bread_type_nut_free_title, | ||
R.string.bread_type_nut_free_des | ||
), | ||
SUGARFREE( | ||
R.string.bread_type_sugar_free_ampl, | ||
R.string.bread_type_sugar_free_title, | ||
R.string.bread_type_sugar_free_des, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 대문자로 보내도 괜찮다고 해서 따로 string 리소스 추가 안 하고 그냥 저 값만 보내두 됨요! BreadFilterType
의 이름!!! 이라구 하나 아무튼 그거 ㅋㅋㅋ ㅜ 나 다른 엠플 붙인 거 그 방식대로 해놨으니까 참고하면 좋을 듯!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 내가 딱 말하려 했는데 ㅋ.ㅋ 대문자로 보내주세얌 ~~
@StringRes val amplitudeRes: Int, | ||
@StringRes val titleRes: Int | ||
) { | ||
NUTRIENT( | ||
R.string.nutrient_type_nutrient_open_ampl, | ||
R.string.nutrient_type_nutrient_open | ||
), | ||
INGREDIENT( | ||
R.string.nutrient_type_ingredient_open_ampl, | ||
R.string.nutrient_type_ingredient_open | ||
), | ||
NOT( | ||
R.string.nutrient_type_not_open_ampl, | ||
R.string.nutrient_type_not_open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얘도 ~ 헤헤
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오키얌
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢