Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod] amplitude event를 전체적으로 수정 #208

Merged
merged 10 commits into from
Sep 29, 2023
Merged

Conversation

Dan2dani
Copy link
Member

Related issue 🛠

Work Description ✏️

  • 온보딩 텍소노미 전반적으로 event name, property name 노션과 같게 수정 및 이벤트 찍히는 시점 수
  • 필터 완료 click, complete(property 감싸서) 구분 및 구현

Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨숩니당 ~~

Comment on lines +83 to +85
if (viewModel.previousActivity.value == FilterInfoType.ONBOARDING && eventToTrack != null) {
AmplitudeUtils.trackEvent(eventToTrack)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

걍 천재 만재다

@Dan2dani Dan2dani merged commit 9f51074 into develop Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[mod] amplitude 전체 확인 및 수정
2 participants