[mod] 필터뷰 슈정 #221
Merged
[mod] 필터뷰 슈정 #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dan2dani
approved these changes
Feb 11, 2024
| @StringRes val titleRes: Int, | ||
| @StringRes val desRes: Int, | ||
| ) { | ||
| GLUTENFREE( | ||
| R.string.bread_type_gluten_free_title, | ||
| R.string.bread_type_gluten_free_des | ||
| id = 1, |
| layout="@layout/view_bread_type_button" | ||
| selected="@{viewModel.breadFilterType.get(BreadFilterType.GLUTENFREE)}" | ||
| selected="@{viewModel.breadFilterTypeList.contains(BreadFilterType.GLUTENFREE.id)}" |
There was a problem hiding this comment.
건빵 코드를 다시 보니 ui 랜더링 시점에 ui를 어떻게 보여줄지를 결정하는 로직들이 많군용 지금 같이 contain 여부를 ui에서 확인하는 ! 이거 나중에 다 뷰모델 등으로 이전하고 ui에서는 정말 보여주기만 하는 방식으로에 대한 고민이 필요할 거 같아욤 나중에 이부분은 같이 고민해보면 좋을 거 같습니당 ~
| ) | ||
| val breadFilterTypeList: MutableStateFlow<List<Int>> = MutableStateFlow(emptyList()) | ||
| private val _nutrientFilterType = MutableStateFlow<NutrientFilterType?>(null) | ||
| val nutrientFilterType get() = _nutrientFilterType.asStateFlow() | ||
| val isFilterBtnEnabled: StateFlow<Boolean> = combine( |
There was a problem hiding this comment.
combine을 사용하지 않고 이를 해결할 수 있는 방법은 없는지 알아봐도 좋을 거 같아영
There was a problem hiding this comment.
여러 개의 flow를 한 번에 관찰해야 하는 경우에 combine, zip, merge 등등 여러 방법을 사용할 수 있지만, 지금처럼 여러 개의 flow를 관찰하고 결과를 내야 하는 경우에는 combine을 사용하는 방법이 제일 적합할 것 같다는 생각이 듭니다요,,! 다른 좋은 방법이 있을까염?
| @@ -33,33 +33,21 @@ class FilterSettingViewModel @Inject constructor( | |||
| val previousActivity get() = _previousActivity.asStateFlow() | |||
There was a problem hiding this comment.
지금 보니 flow가 정말 많이 사용됐다는 느낌이 드는거 같아욤 flow를 유사한 거 까리 뭉텅이로 같이 사용하는 방식으로 해도 좋을 거 같습니당
| } | ||
|
|
||
| fun setUserFilter() { | ||
| viewModelScope.launch { | ||
| _mainPurposeType.value?.let { | ||
| RequestSettingFilter( | ||
| it.name, |
# Conflicts: # app/src/main/java/com/sopt/geonppang/presentation/filterSetting/FilterSettingViewModel.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
UX Writing 수정
건너뛰기 위치 변경
성분공개 필터 중복선택 -> 단일선택 변경
회원 필터 정보 변경하기 API 변경사항 반영 (request, response 모두 List 형태로 변경)
유저 필터칩 조회 API 변경사항 반영 (response List 형태로 변경)
필터 관련 택소노미 변경
Screenshot 📸
Screen_recording_20240205_182958.mp4
Uncompleted Tasks 😅
To Reviewers 📢
끝났습니다요 ~ 신난당 ㅋ