Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 마이페이지 회원정보 조회 api 연동 #52

Merged
merged 11 commits into from
Jul 20, 2023

Conversation

jooyyoo
Copy link
Member

@jooyyoo jooyyoo commented Jul 20, 2023

Related issue 🛠

Work Description ✏️

  • 마이페이지 회원정보 조회 api 연동

Screenshot 📸

image

image

Uncompleted Tasks 😅

  • api 연동

To Reviewers 📢

# Conflicts:
#	app/src/main/java/com/sopt/geonppang/data/interceptor/AuthInterceptor.kt
# Conflicts:
#	app/src/main/java/com/sopt/geonppang/presentation/mypage/MyPageFragment.kt
#	app/src/main/java/com/sopt/geonppang/presentation/mypage/MyPageViewModel.kt
Copy link
Member

@Dan2dani Dan2dani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

집에 와서 같이 봅시당

Comment on lines 8 to 9
constructor() : this("", "", BreadType(0, "", false, false, false, false))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

@@ -19,6 +19,8 @@ class MyPageFragment : BindingFragment<FragmentMyPageBinding>(R.layout.fragment_
binding.viewModel = viewModel
binding.lifecycleOwner = this

viewModel.fetchMypageInfo()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뷰모델 init{} 블록으로 이동

Comment on lines 21 to 22
private var _mypageInfoState = MutableStateFlow(Profile())
val mypageInfoState get() = _mypageInfoState.asStateFlow()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

뭔가 이상한데...?

Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 🍞

# Conflicts:
#	app/src/main/java/com/sopt/geonppang/presentation/review/ReviewWritingActivity.kt
Copy link
Member

@Dan2dani Dan2dani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셧습니당 ~~

@jooyyoo jooyyoo merged commit 3a0a63f into develop Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 마이페이지 회원정보 조회 api 연동
3 participants