feat(contacts): add new contact types: signee & assisting #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoronex
changed the title
Yoronex
approved these changes
Feb 13, 2025
Yoronex
requested changes
Feb 14, 2025
- make email optional for contacts of type old - make firstname optional
LuukBlankenstijn
force-pushed
the
feature/new-company-contact-types
branch
from
cdd279d to
26fd2e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds two new company contact types. These contact types are special in the sense that for contacts of this type, an email-adress is not required. This pull-request adds a check to the validation of contact parameters that allows email to be empty if the type is one of the aforementioned types.
Types of changes