Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/inactive administrative cost #343

Open
wants to merge 136 commits into
base: develop
Choose a base branch
from

Conversation

SvenMokveldje
Copy link
Contributor

Created the inactive administrative cost feature. BAC treasurer can now check who has been inactive at SudoSOS and either send them an notification and after 3 years fine them. This will fine them until they have a balance of 0. After which the BAC treasurer can disable those accounts.

(Auto locking will be added once this is implemented)

You can check inactive users, notify them, handout the administrative costs, create the inactive administrative cost entity and delete it. There is no update function as you would never change the amount (this is fixed) so the only update would be to delete it and lastly get certain entities.

@SvenMokveldje
Copy link
Contributor Author

For the test fails: The first one, I do not understand why the post-miration-test tries to equal it to 20, as the default_pagination should be either that of process.env which is 20 or the default put in by Samuel which is 25.

The second one, does not fail on my machine (hihi), but as I take a id bigger than that should exist it should be equal to null. But maybe someone with more knowledge can take a crack at it.

@SvenMokveldje SvenMokveldje force-pushed the feature/inactive-administrative-cost branch from 055ebd7 to a76d248 Compare November 11, 2024 15:09
@JustSamuel
Copy link
Contributor

@SvenMokveldje small thing I thought about, if we want to deploy this we also need to think about the impact. This is something the BACPM will need to add to her bookkeeping, and therefore should already come with the pdf functionality implemented.

We could make it a different PR, but before deploying this to main it should be possible to get a pdf overview of the handed out administration costs.

Also maybe an interface on the frontend side of things? What do you think.

@SvenMokveldje
Copy link
Contributor Author

@JustSamuel I can still look into the PDF part as part of this PR as I agree that this should be looked into. It is however a very small things that only happens once a year (at least my idea was to always check it on the first of July or maybe once a quartile). Next to that from what I see, people that do not use it will mostly likely be disabled first by having too many fines.

So, I think in the frontend you could add this to one of the already existing overviews?

@JustSamuel
Copy link
Contributor

quick question @SvenMokveldje, the whole process now works with that the BACPM remembers to do this right? As in everything is done manually?

Maybe we should consider a reminder mail for the BACPM, at the first of july, weekly, until its done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants