Complete Type Safety: Eliminating All Pyright Errors#245

Merged

josephdviviano merged 74 commits intomasterfrom fixpyright

Mar 3, 2025

Commits on Feb 21, 2025

fix: pyright issues in env.py
Salem Lahlou
committed
Merge branch 'master' into fixpyright
Salem Lahlou
committed
update pre commit and pyproject
Salem Lahlou
committed
fix containers getitem
Salem Lahlou
committed
allow a None log_reward
Salem Lahlou
committed
fix return type of to_non_initial_intermediary_and_terminating_states
Salem Lahlou
committed
minor typing changes in DB
Salem Lahlou
committed
minor typing changes in TB
Salem Lahlou
committed
minor typing changes in box utils
Salem Lahlou
committed
fix actions setitem
Salem Lahlou
committed
minor changes in samplers.py
Salem Lahlou
committed
minor changes in states.py
Salem Lahlou
committed
minor changes in FM
Salem Lahlou
committed
minor changes in line.py
Salem Lahlou
committed
minor changes in modules.py
Salem Lahlou
committed
ensure output of loss is always a tensor
Salem Lahlou
committed
add setters for input and output dim of MLP
Salem Lahlou
committed
remove some pyright ignore
Salem Lahlou
committed

Commits on Feb 22, 2025

Update Actions class type hints
Salem Lahlou
committed
Add pre-commit configuration for Python code quality
Salem Lahlou
committed
Refactor states.py type hints and error handling
Salem Lahlou
committed
Add states_from_batch_shape method to DiscreteEnv
Salem Lahlou
committed
Add StatePairs container for managing state pairs with optional conditioning
Salem Lahlou
committed
Add loss_from_trajectories method to GFlowNet base class
Salem Lahlou
committed
Import StatePairs container in containers module
Salem Lahlou
committed
Update preprocessors to use DiscreteStates type hint
Salem Lahlou
committed
Refactor Trajectories to use StatePairs for state processing
Salem Lahlou
committed
Refactor FMGFlowNet to use StatePairs for state processing
Salem Lahlou
committed
Refactor type hints and remove pyright ignore comments
Salem Lahlou
committed
Refactor ReplayBuffer to support generic container types
Salem Lahlou
committed
Add test for flow matching state pairs processing
Salem Lahlou
committed
Update README documentation for FMGFlowNet and training sample types
Salem Lahlou
committed
Remove unused import of States in training and test modules
Salem Lahlou
committed
Remove unused import of TBGFlowNet in train_box.py
Salem Lahlou
committed
Simplify type handling and remove unnecessary type casting in training examples
Salem Lahlou
committed
Update pyright configuration to include additional directories
Salem Lahlou
committed
Add type casting for last states in train_hypergrid_simple.py
Salem Lahlou
committed
Refactor Trajectories and MLP to improve type safety and module handling
Salem Lahlou
committed
Remove unnecessary TYPE_CHECKING imports in training examples
Salem Lahlou
committed
Improve log_probs handling in Trajectories and update replay buffer test
Salem Lahlou
committed
Refactor replay buffer test to improve object handling and consistency
Salem Lahlou
committed
Improve null handling and log probability computation in LocalSearchSampler
Salem Lahlou
committed
Remove unnecessary type ignore comment in sub_trajectory_balance.py
Salem Lahlou
committed
Refactor loss computation in train_conditional.py
Salem Lahlou
committed
Improve type hints and remove pyright ignore comments in test files
Salem Lahlou
committed
Add optional recalculation of log probabilities in detailed balance loss
Salem Lahlou
committed
Update README.md with comprehensive development and project setup details
Salem Lahlou
committed
Update CI workflows to use pre-commit and latest GitHub Actions versions
Salem Lahlou
committed
hopefully final precommit commit
Salem Lahlou
committed
Move Pyright configuration from pyproject.toml to pyrightconfig.json
Salem Lahlou
committed

Commits on Feb 23, 2025

Consolidate Pyright and pre-commit configuration
Salem Lahlou
committed
Update __all__ in package __init__.py files
Salem Lahlou
committed
black+isort Refactor code formatting and import statements across multiple files
Salem Lahlou
committed
Remove unused variables and add explicit test case for local search
Salem Lahlou
committed
remove double import
Salem Lahlou
committed
Fix tensor shape and indexing in LocalSearchSampler
Salem Lahlou
committed
temp addition
Salem Lahlou
committed
Add type checks and assertions to improve type safety
Salem Lahlou
committed

Commits on Feb 25, 2025

Address Sanghyeok's comments: Refactor containers and GFlowNet modules
Salem Lahlou
committed
Simplify type variable definition in GFlowNet base module
Salem Lahlou
committed
refactor the LocalSearchSampler
hyeok9855
committed

Commits on Feb 26, 2025

Update replay buffer capacity parameter name in train_hypergrid.py
Salem Lahlou
committed
Enhance StatePairs __getitem__ docstring
Salem Lahlou
committed
remove useless variable
Salem Lahlou
committed
Merge branch 'fixpyright' of https://github.com/GFNOrg/torchgfn into fixpyright
Salem Lahlou
committed
blackifying
Salem Lahlou
committed
sometimes, when using replay buffer, there is no valid transition on which to calulcate PB. this fixes that
Salem Lahlou
committed
allow log_probs to be None in transitions
Salem Lahlou
committed
Fix StatePairs length calculation to handle unequal state list sizes
Salem Lahlou
committed
Add test for hypergrid losses and replay buffer configurations
Salem Lahlou
committed
Remove log_rewards attribute from States class and update related methods
Salem Lahlou
committed
Refactor ReplayBuffer initialization to improve type handling
Salem Lahlou
committed

Commits on Feb 27, 2025

revert the removed check. it's useful
Salem Lahlou
committed

Commits on Feb 28, 2025

Update dependency versions and improve warning message
Salem Lahlou
committed