Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from TensorDict to torch_geometric #253

Merged
merged 34 commits into from
Mar 5, 2025
Merged

switch from TensorDict to torch_geometric #253

merged 34 commits into from
Mar 5, 2025

Conversation

josephdviviano
Copy link
Collaborator

A continuation of this PR: alip67#1

Here, we replace the custom graph implementation using TensorDict by the Data and Batch classes from pytorch_geometric.

younik and others added 23 commits February 26, 2025 18:11
@younik
switch from torch_geoemtric to TensorDict
0a1f8e1
@younik
update train_graph_ring
382be45
@younik
fix all problems
939bdab
@younik
remove node_index
0f57485
@younik
move dep
911157c
@younik
Merge branch 'graph-states' into graph-states
313562e
@hyeok9855
fix pyproject.toml
8806cda
@hyeok9855
change state type hinting from Tensordict to torch_geometric Data
ce287eb
@hyeok9855
add settings that achieve 95% in the ring generation (directed) with …
7607945 
…four nodes
@hyeok9855
rename test_state to test_graph_states
e918ac7
@josephdviviano
renamed Batch to GeometricBatch, Data to GeometricData
fb4445c
@josephdviviano
renamed Batch to GeometricBatch, Data to GeometricData
461fa2d
@josephdviviano
docstring
0af5747
@josephdviviano
fixed imports
e717d04
@josephdviviano
merge
be148ae
@hyeok9855
Merge pull request #250 from younik/graph-states
3372702 
Graph states with torch_geometric
@josephdviviano
Merge branch 'graph-state-pyg' of github.com:GFNOrg/torchgfn into for…
3a3e41d 
…ked-graph-states
@hyeok9855
batch_shape as tuple for all Graph things
8e496d8
@hyeok9855
remove since it's redundant with
2b076e0
@hyeok9855
apply black
eb7c9ca
@hyeok9855
apply black
51518ab
@hyeok9855
resolve flake-8 issues
f90fa7f
@hyeok9855
fix ring exp
67349b6
@josephdviviano josephdviviano self-assigned this Mar 4, 2025
josephdviviano
josephdviviano commented Mar 4, 2025
View reviewed changes
Copy link
Collaborator Author

@josephdviviano josephdviviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but I need someone else to sign off).

hyeok9855
hyeok9855 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@hyeok9855 hyeok9855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josephdviviano josephdviviano merged commit 4abeadd into graph-states Mar 5, 2025
2 checks passed
@josephdviviano josephdviviano deleted the graph-state-pyg branch March 11, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyeok9855 hyeok9855 hyeok9855 approved these changes

@saleml saleml Awaiting requested review from saleml

@younik younik Awaiting requested review from younik

Assignees

@josephdviviano josephdviviano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephdviviano @hyeok9855 @younik